Skip to content

[wip] feat: add depends_on to store service files for parallel #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[wip] feat: add depends_on to store service files for parallel #1208

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4d5f14
add depends on
tedim52 Oct 2, 2025
0d4f793
add back verifies
tedim52 Oct 2, 2025
de1b354
fix typo
tedim52 Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/prelaunch_data_generator/validator_keystores/validator_keystore_generator.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def generate_validator_keystores(plan, mnemonic, participants, docker_cache_para
keystore_stop_index - 1,
)
artifact_name = plan.store_service_files(
service_name, output_dirpath, name=artifact_name
service_name, output_dirpath, name=artifact_name, depends_on=command_result["output"],
)

base_dirname_in_artifact = shared_utils.path_base(output_dirpath)
Expand Down Expand Up @@ -190,7 +190,10 @@ def generate_validator_keystores(plan, mnemonic, participants, docker_cache_para
)

prysm_password_artifact_name = plan.store_service_files(
service_name, PRYSM_PASSWORD_FILEPATH_ON_GENERATOR, name="prysm-password"
service_name,
PRYSM_PASSWORD_FILEPATH_ON_GENERATOR,
name="prysm-password",
depends_on=write_prysm_password_file_cmd_result["output"]
)

result = keystores_result.new_generate_keystores_result(
Expand All @@ -203,7 +206,7 @@ def generate_validator_keystores(plan, mnemonic, participants, docker_cache_para


# this is like above but runs things in parallel - for large networks that run on k8s or gigantic dockers
def generate_valdiator_keystores_in_parallel(
def generate_validator_keystores_in_parallel(
plan, mnemonic, participants, docker_cache_params
):
service_names = launch_prelaunch_data_generator_parallel(
Expand Down
Loading