feat: support remote_signer in participants_matrix#1424
Merged
Conversation
qu0b
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1169.
participants_matrixcould not configure a remote signer. Aremote_signerdimension was already declared insanity_check.star'sPARTICIPANT_MATRIX_PARAMS, butinput_parser.staronly iteratedel/cl/vcand never merged it into participants — so it was dead config. Putting remote-signer fields underclalso failed sanity validation (use_remote_signer is not an attribute).Changes
input_parser.star: the matrix builder now also reads theremote_signerdimension and merges each item's keys into the participant (same wayvcis merged), wrapped in afor ... else [{}]so it's optional. Defining a non-emptyremote_signerentry impliesuse_remote_signer = true— no separate flag to set.README.md: documented theremote_signermatrix dimension with an example, noting that defining an entry enables it automatically and that it requiresuse_separate_vc: trueon the matchingclitem..github/tests/remote-signer-matrix.yaml: example/config exercising the new dimension.Usage
Just defining the
remote_signerentry enables it. A remote signer requiresuse_separate_vc: trueon the matchingclitem (existing validation ininput_parser.star).kurtosis lintpasses.