docs: clarify grafana additional_dashboards requires a github/http locator#1425
Open
barnabasbusa wants to merge 2 commits into
Open
docs: clarify grafana additional_dashboards requires a github/http locator#1425barnabasbusa wants to merge 2 commits into
barnabasbusa wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #784.
grafana_params.additional_dashboardsis passed toplan.upload_files(...)ingrafana_launcher.star. Per Kurtosis,upload_filesaccepts a GitHub locator, a path within the current package, or an absolute http(s) URL. Because that call executes insideethpandaops/ethereum-package, a relative/local path supplied by a consumer package resolves against ethereum-package and fails:This is inherent to Kurtosis's locator model — a relative consumer path cannot resolve against the consumer when the
upload_filescall lives in the dependency. The supported approach is an absolutegithub.com/<org>/<repo>/pathlocator (or an http(s) URL) pointing at your own repo.Change
Documentation only — expands the
additional_dashboardscomment inREADME.mdto spell out that entries must be a GitHub locator or absolute http(s) URL, and that local/relative paths won't work when inheriting the package.