-
Notifications
You must be signed in to change notification settings - Fork 218
feat: add vouch #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
TobiWo
wants to merge
6
commits into
ethpandaops:main
Choose a base branch
from
TobiWo:feature/add-vouch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: add vouch #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02fbb35
to
e14284b
Compare
e14284b
to
9e7bb75
Compare
Signed-off-by: Barnabas Busa <[email protected]>
Looks like this pr wasn't actually tested with vouch yet :D
|
Hi @barnabasbusa , sorry didn't had the time to work on it further. However, a friend is still working on it although he didn't commit anything yet. I wonder why it wasn't a draft already. I'm pretty sure I set it as draft. Anyway, if you are fine with it we can keep it open. |
Happy to review when its ready. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will add vouch as vc client.