Skip to content

feat: add vouch #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat: add vouch #809

wants to merge 6 commits into from

Conversation

TobiWo
Copy link
Contributor

@TobiWo TobiWo commented Oct 24, 2024

Summary

This PR will add vouch as vc client.

@TobiWo TobiWo force-pushed the feature/add-vouch branch from 02fbb35 to e14284b Compare October 24, 2024 06:46
@TobiWo TobiWo force-pushed the feature/add-vouch branch from e14284b to 9e7bb75 Compare October 24, 2024 06:49
@barnabasbusa barnabasbusa linked an issue Dec 6, 2024 that may be closed by this pull request
@barnabasbusa barnabasbusa marked this pull request as ready for review April 3, 2025 11:32
@barnabasbusa
Copy link
Contributor

Looks like this pr wasn't actually tested with vouch yet :D

  Caused by: An error occurred waiting for all TCP and UDP ports to be open for service 'vc-1-besu-grandine-vouch' with private IP '172.16.0.21'; this is usually due to a misconfiguration in the service itself, so here are the logs:
  == SERVICE 'vc-1-besu-grandine-vouch' LOGS ===================================
  unknown flag: --beacon-node
  Usage of /app/vouch:
        --base-dir string                base directory for configuration files
        --beacon-node-address string     Address on which to contact the beacon node
        --log-file string                redirect log output to a file
        --log-level string               minimum level of messsages to log (default "info")
        --profile-address string         Address on which to run Go profile server
        --proposer-config-check string   show the proposer configuration for the given public key and exit
        --tracing-address string         Address to which to send tracing data
        --version                        show Vouch version and exit
  unknown flag: --beacon-node
  
  == FINISHED SERVICE 'vc-1-besu-grandine-vouch' LOGS ===================================
  Caused by: An error occurred while waiting for all TCP and UDP ports to be open
  Caused by: Unsuccessful ports check for IP '172.16.0.21' and port spec '{privatePortSpec:0x4000b5f590}', even after '240' retries with '500' milliseconds in between retries. Timeout '2m0s' has been reached
  Caused by: An error occurred while calling network address '172.16.0.21:8080' with port protocol 'TCP' and using time out '200ms'
  Caused by: dial tcp 172.16.0.21:8080: connect: no route to host

@barnabasbusa barnabasbusa marked this pull request as draft April 3, 2025 11:54
@TobiWo
Copy link
Contributor Author

TobiWo commented Apr 3, 2025

Hi @barnabasbusa , sorry didn't had the time to work on it further. However, a friend is still working on it although he didn't commit anything yet. I wonder why it wasn't a draft already. I'm pretty sure I set it as draft. Anyway, if you are fine with it we can keep it open.

@barnabasbusa
Copy link
Contributor

Happy to review when its ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Vouch as validator client option
2 participants