fix(prefunded-accounts): use pop() on PRE_FUNDED_ACCOUNTS to avoid key reuse #988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested Commit Message
Pull Request Description
Goal
Ensure that no two services ever share the same prefunded account by switching from static-index lookups to a
.pop()
-based allocation from a mutable stack.What Changed
prefunded_accounts
list into a localaccounts_stack = prefunded_accounts[:]
.prefunded_accounts[<n>]
or slice (e.g.[6:8]
) withaccounts_stack.pop()
calls.How to Test
Related Issue
Closes [#360](#360)