handling vignettes/articles subfolder and custom sidebars#355
Draft
d-morrison wants to merge 12 commits into
Draft
handling vignettes/articles subfolder and custom sidebars#355d-morrison wants to merge 12 commits into
vignettes/articles subfolder and custom sidebars#355d-morrison wants to merge 12 commits into
Conversation
Owner
|
Hi @d-morrison, thanks for the PR! I'll take a closer look tomorrow but I already have a few comments:
|
Author
@etiennebacher thanks, will do! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope it's ok to send this PR; feel free to close if not!
I attempted fixes for two problems I ran into (reprex: https://github.com/UCD-SERG/rpt):
find .qmd files in the
vignettes/articlessubfolder (https://r-pkgs.org/vignettes.html#sec-vignettes-article)include singleton entries in custom sidebars in preprocessed
_quarto.yml2b. Print the preprocessed
_quarto.ymlin verbose mode (helped diagnose 2)Glad to revise as helpful, if this is of interest. Thanks for this awesome package!