Skip .qmd generation for .Rd files that didn't change.#360
Open
gustavdelius wants to merge 1 commit into
Open
Conversation
etiennebacher
requested changes
Apr 2, 2026
Owner
etiennebacher
left a comment
etiennebacher
left a comment
There was a problem hiding this comment.
Thanks, and sorry for the delay to review this. I'll try to test this locally by the end of the week but in the meantime can you address the comment?
Also, you need to format this with Air and to add an item in NEWS.md.
Comment on lines
+103
to
+106
| rd_stems <- fs::path_ext_remove(basename( | ||
| list.files(fs::path_join(c(path, "man")), | ||
| pattern = "\\.Rd$" | ||
| ) |
Owner
There was a problem hiding this comment.
Can you extract an intermediate object from this? It's quite hard to read as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I render the documentation website with quarto with
altdoc::render_docs(freeze = TRUE)it re-processes all man pages even though none of them have changed. The mechanism for skipping the generation of new .qmd files for man pages whose .Rd file had not changed is not working. There are two issues:This pull request fixes both these issues.