Add an option for a Wallet to configure supported Proof types#517
Add an option for a Wallet to configure supported Proof types#517dzarras wants to merge 4 commits into
Conversation
495e0b2 to
d439e66
Compare
|
@babisRoutis, @vafeini PR now targets release/0.12.0 and is ready for review. |
| * @property deviceBound Whether the Wallet supports device-bound attestations, and the Proofs it supports. | ||
| */ | ||
| data class ProofsConfig( | ||
| val supportsNonDeviceBound: Boolean, |
There was a problem hiding this comment.
Can you please rename it to isNoProofSupported?
The non-device-bound term is not recognizable immediately in a OpenId4VCI context.
There was a problem hiding this comment.
Device-bound as a term is used neither in OpenID4VCI nor HAIP.
If we rename the property supportsNonDeviceBound we also have to rename the property deviceBound and the data class DeviceBound as well.
Any ideas/suggestions for the later?
| */ | ||
| data class DeviceBound( | ||
| val algorithms: Set<JWSAlgorithm>?, | ||
| val proofs: Set<Proof>, |
There was a problem hiding this comment.
I don't like the Set approach, but it works
There was a problem hiding this comment.
@dzarras Can you please consider #508 (comment)
Let's discuss this offline
2df3e0e to
03030b9
Compare
|
@babisRoutis, @vafeini Rebased against release/0.12.0. Please check again. |
03030b9 to
43ca4af
Compare
|



This PR add a new option called
proofsinOpenId4VCIConfigas a means for a Wallet to configure the supported Attestation/Proofs.Current a Wallet can configuration the following:
The new configuration option is taken into account just before generating the Proofs for the Credential Request.
Before generating the Proofs for the Credential Request, we check for the selected Credential Configuration:
Closes #508