-
Notifications
You must be signed in to change notification settings - Fork 4
Load dimensions from server, reload after navigation change #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thet
wants to merge
38
commits into
scrum-3249
Choose a base branch
from
scrum-3351
base: scrum-3249
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading the few polyfills we need in Patternslib is done by Patternslib itself.
Remove the polyfills-loader.js script.
Test Plone 6.1
Update the pre-commit action
Add a new ``@search-with-version-description`` endpoint to search for surveys and return the survey version description instead of the survey group description.
Views for Quaive
Make the risk view more similar to the client one
Changes for OiRA creator that blend the fields from the tool and the tools version
This tracking snippet deactivates automatic link tracking for the report download buttons and tracks them manually. It removes the session id segment from the URL so that all downloads can be grouped together in Matomo and to not reveal DSGVO relevant data. This requires Matomo 5+ as the deactivation does not work reliably (Matomo 4) or at all (Matomo 3) in earlier Matomo versions. Ref: scrum-3249
This tracking snipped just adds a "setCustomUrl" variable which has the session id segment removed but leaves all the other information as-is. This is sufficient for the requirement of scrum-3249. Ref: scrum-3249
Ref: scrum-3351
Ref: scrum-3351
… is not a bad choice due to var hoisting, which is in this case even wanted.
Ref: scrum-3351
Ref: scrum-3351
Ref: scrum-3249
…URL and referrer URL. Ref: scrum-3249
Ref: scrum-3249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obsoletes: #323
Related: euphorie/Euphorie#838
NOTE: Fetching the custom dimension from an endpoint is yet disabled as this needs this PR to be finished: euphorie/Euphorie#838
NOTE 2: the tracking reload mechanism is not using the navigate event polyfill from Patternslib, as this can also be done just with standard pat-inject events and comparing the new location.href to a previous one.
Ref: scrum-3351
Ref: scrum-3249