-
Notifications
You must be signed in to change notification settings - Fork 5
Load dimensions from server, reload after navigation change #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tracking snippet deactivates automatic link tracking for the report download buttons and tracks them manually. It removes the session id segment from the URL so that all downloads can be grouped together in Matomo and to not reveal DSGVO relevant data. This requires Matomo 5+ as the deactivation does not work reliably (Matomo 4) or at all (Matomo 3) in earlier Matomo versions. Ref: scrum-3249
This tracking snipped just adds a "setCustomUrl" variable which has the session id segment removed but leaves all the other information as-is. This is sufficient for the requirement of scrum-3249. Ref: scrum-3249
Ref: scrum-3351
Ref: scrum-3351
… is not a bad choice due to var hoisting, which is in this case even wanted.
Ref: scrum-3351
Ref: scrum-3351
Ref: scrum-3249
…URL and referrer URL. Ref: scrum-3249
Ref: scrum-3249
pilz
approved these changes
May 21, 2025
Member
pilz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated by Gari.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obsoletes: #323
Related: euphorie/Euphorie#838
NOTE: Fetching the custom dimension from an endpoint is yet disabled as this needs this PR to be finished: euphorie/Euphorie#838
NOTE 2: the tracking reload mechanism is not using the navigate event polyfill from Patternslib, as this can also be done just with standard pat-inject events and comparing the new location.href to a previous one.
Ref: scrum-3351
Ref: scrum-3249
PRs
euphorie/Euphorie#838
#324