fix: show onboarding after OAuth signup without a reload#136
Merged
Conversation
A fresh account created via the external PDS OAuth flow never runs the
in-app signup wizard, so we start onboarding on the web OAuth callback.
It previously did this with persisted.write('onboarding', ...), but on
web that never activated onboarding in the current tab: OnboardingProvider
is mounted above the session and is never remounted by login(), and
persisted.write() does not fire local onUpdate listeners (its cross-tab
BroadcastChannel never echoes back to the sender). The wizard only
appeared after a manual reload, which re-read the persisted step.
Drive the in-memory onboarding reducer instead (dispatch 'start', which
also persists the step) by threading an onboarding dispatch from InnerApp
into tryFinishWebOAuthSignIn.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh account created via the external PDS OAuth flow never runs the in-app signup wizard, so we start onboarding on the web OAuth callback. It previously did this with persisted.write('onboarding', ...), but on web that never activated onboarding in the current tab: OnboardingProvider is mounted above the session and is never remounted by login(), and persisted.write() does not fire local onUpdate listeners (its cross-tab BroadcastChannel never echoes back to the sender). The wizard only appeared after a manual reload, which re-read the persisted step.
Drive the in-memory onboarding reducer instead (dispatch 'start', which also persists the step) by threading an onboarding dispatch from InnerApp into tryFinishWebOAuthSignIn.