Skip to content

fix youtube embeds #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flo-bit merged 1 commit into from
Jun 1, 2026
Merged

fix youtube embeds #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ export default defineConfig(
'.husky/**',
'patches/**',
'*.html',
// Eurosky fork: static iframe player scripts (browser globals like YT /
// onYouTubeIframeAPIReady, not app code). Mirrors the bskyweb/** ignore.
'web/iframe/**',
'bskyweb/**',
'bskyembed/**',
'bskyogcard/**',
Expand Down
9 changes: 5 additions & 4 deletions src/lib/strings/embed-player.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@ import {IS_WEB} from '#/env'
const {height: SCREEN_HEIGHT} = Dimensions.get('window')

const IFRAME_HOST = IS_WEB
? // @ts-ignore only for web
window.location.host === 'localhost:8100'
? 'http://localhost:8100'
: 'https://bsky.app'
? // @ts-ignore only for web -- Eurosky fork: serve the YouTube iframe player
// from our own origin instead of bsky.app. bsky.app/iframe/* sends
// X-Frame-Options: SAMEORIGIN, so it refuses to be framed cross-origin. The
// player files live in web/iframe/* and are copied to the web build root.
window.location.origin
: __DEV__ && !process.env.JEST_WORKER_ID
? 'http://localhost:8100'
: 'https://bsky.app'
Expand Down
19 changes: 19 additions & 0 deletions web/iframe/youtube.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<!DOCTYPE html><meta name="viewport" content="width=device-width, initial-scale=1" />
<style>
body {
margin: 0;
}
.container {
position: relative;
overflow: hidden;
width: 100vw;
height: 100vh;
}
.video {
position: absolute;
width: 100vw;
height: 100vh;
}
</style>
<div class="container"><div class="video" id="player"></div></div>
<script src="youtube.js"></script>
35 changes: 35 additions & 0 deletions web/iframe/youtube.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
const url = new URL(window.location)
const viewport = document.querySelector('meta[name=viewport]')

const tag = document.createElement('script')
tag.src = 'https://www.youtube.com/iframe_api'
const firstScriptTag = document.getElementsByTagName('script')[0]
firstScriptTag.parentNode.insertBefore(tag, firstScriptTag)

let player
function onYouTubeIframeAPIReady() {
let videoId = url.searchParams.get('videoId')
videoId = decodeURIComponent(videoId)
videoId = videoId.replace(/[^a-zA-Z0-9_-]/g, '')
if (videoId.length !== 11) throw new Error('Invalid video ID')

let start = url.searchParams.get('start')
start = start.replace(/[^0-9]/g, '')

player = new YT.Player('player', {
width: '1000',
height: '1000',
videoId,
playerVars: {
autoplay: 1,
start,
rel: 0,
loop: 0,
playsinline: 1,
origin: url.origin,
},
})
}
function onPlayerReady(event) {
event.target.playVideo()
}
Loading