test: mock repo clone git execution#3
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a mockable git command runner to improve the testability of git-related operations. It refactors the existing execution logic to use this runner and adds detailed assertions in the repository clone tests to verify command arguments. Feedback focuses on enhancing the implementation's robustness and testability, specifically by moving the runner into the App struct to support parallel testing, incorporating context.Context for better process management, and using cmd.InOrStdin() for flexible input handling. Additionally, it is recommended to refactor duplicated mocking logic in tests into a shared helper function.
f3bb77c to
1ec999d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note: full local go test ./internal/cmd still fails in this sandbox at TestNewRootCmd_ConfigLoadError, unrelated to the clone timeout.