[chore] Relax rack dependency - #25
Conversation
|
Hey @chytreg , please try to fix travis build. |
|
(That build error, isn't that transient? It ran 5 months ago, with your typical "network glitch" output. If there were a re-try button, I'd push it, but only the owner can push that button.) |
0317647 to
271b4dd
Compare
|
Unfortunately, there is a problem with ruby version. Rack 2, requires >= 2.2.2 |
|
@chytreg perhaps this would help? http://guides.rubygems.org/specification-reference/#add_runtime_dependency |
|
The question is how to support new features for the older version. If we add runtime dependency this will be breaking change (only rack >=2, only ruby >=2.2.2). Probably we should release some major version of Envied WDYT, and adjust test runner to skip ruby versions prior than 2.2.2 |
|
Let me suggest an if RUBY_VERSION < '2.2.2'
spec.add_dependency "rack", "~> 1.4"
else
spec.add_dependency "rack", ">= 1.4"
endIt seems only the parse_query from Rack::Utils is used. Line 12 in cdaf3f1 |
|
Would the suggestion @mpalmer made which uses |
cd4a1d7 to
e406eee
Compare
|
@javierjulio & @mpalmer I've managed to make it work on any ruby version. |
- allows to work with Rails 5 - set proper rack dependency based on ruby version - solve problem with undefined method `spec' for nil:NilClass travis-ci/travis-ci#5239 - test against ruby 2.2.0 and 2.3.0
97487d4 to
227a2a1
Compare
|
FYI it's rebased and ready to merge |
|
This is great! @eval, if you could get 'round to merging this, it would make my day! |
|
It'd be great to get this merged, or a list of remaining tasks to get it across the line. Thanks for this tool <3 |
|
I've asked @eval to consider a set of releases for Envied in #29 and offered to take ownership of getting them out if he wants. I included this PR as the first release to go out as a patch update. Other issues have been organized into new minor releases. I would love feedback from the rest of you. |
|
Thanks so much for doing this @chytreg! ❤️ |
I use the gem with rails 5 which works on rack 2.0 only