fix: address validation length mismatch and directory verification#4
Merged
Conversation
- Update SafeString schema max length from 1000 to 2000 to match usage - Add fs.lstat check in findRelatedFiles to skip directories and symlinks - Ensure only actual files are processed in file discovery - Fix ESLint errors and warnings These changes resolve the validation inconsistency and improve security by properly verifying file types before processing. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a validation length mismatch in input validation and improves file type verification by ensuring only files are processed. Key changes include updating the SafeString schema and validateString max length from 1000 to 2000, adding fs.lstat-based file checks in SecureCodeReader, and various ESLint and formatting updates.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/SecureCodeReader.ts | Added fs.lstat check to skip directories and symlinks |
| src/utils/PromptSanitizer.ts | Minor lint and formatting improvements |
| src/utils/InputValidator.ts | Updated max length and adjusted regex for safe string and filename schemas |
| src/utils/ErrorClassifier.ts | Added missing commas for consistency |
| src/utils/CodeReader.ts | Minor code formatting fixes |
| src/services/GeminiService.ts | Added missing commas for consistency |
| src/services/ConversationalGeminiService.ts | Removed unused import of SessionError |
| src/index.ts | Removed unused type import from models |
| src/analyzers/DeepCodeReasonerV2.ts | Added missing commas for consistency |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
1. InputValidator String Length Fix
SafeStringschema max length from 1000 to 2000validateStringdefault maxLength parameter to 20002. SecureCodeReader Directory Verification
findRelatedFilesto verify entries are actual files3. Code Quality Improvements
Testing
🤖 Generated with Claude Code