Zaptec: split go2 and pro templates #21357
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2 and pro to "rfid" and "1p3p" and add info how to change settings to let evcc control the phase switch
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @tbaehler - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| - name: password | ||
| render: | | ||
| type: zaptec | ||
| id: {{ .id }} |
There was a problem hiding this comment.
suggestion (bug_risk): Consider quoting ID and user fields for YAML safety
Quote these fields (e.g. id: "{{ .id }}") to prevent parsing errors with special characters.
Suggested implementation:
id: "{{ .id }}"
user: "{{ .user }}"
andig
reviewed
May 24, 2025
| description: | ||
| de: | | ||
| Im Zaptec-Portal (Installationen -> Einstellungen -> Leistungsregelung) müssen für die Zaptec Go 2 folgende Einstellungen vorgenommen werden: | ||
| <ul> |
There was a problem hiding this comment.
@naltatis I dont think we can use html here?
There was a problem hiding this comment.
But it will look great..
There was a problem hiding this comment.
We should stick to Markdown. Lists are also possible there:
In the Zaptec portal (Installations -> Settings -> Power Management), the following settings must be configured for the Zaptec Go 2:
- Enable "Allow chargers to return to three-phase charging"</li>
- Set "Allowed switches before locking to single-phase charging" to the maximum of 20</li>
- Set "Switch from three-phase to single-phase charging" to 1 A</li>
andig
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
separate doc files to be able to add "1p3p" for go2 and pro.
add additional info how to configure zaptec go2 in portal to work with evcc