Skip to content

Zaptec: split go2 and pro templates #21357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

tbaehler
Copy link
Contributor

separate doc files to be able to add "1p3p" for go2 and pro.
add additional info how to configure zaptec go2 in portal to work with evcc

…2 and pro to "rfid" and "1p3p" and add info how to change settings to let evcc control the phase switch
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tbaehler - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

- name: password
render: |
type: zaptec
id: {{ .id }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (bug_risk): Consider quoting ID and user fields for YAML safety

Quote these fields (e.g. id: "{{ .id }}") to prevent parsing errors with special characters.

Suggested implementation:

  id: "{{ .id }}"

  user: "{{ .user }}"

description:
de: |
Im Zaptec-Portal (Installationen -> Einstellungen -> Leistungsregelung) müssen für die Zaptec Go 2 folgende Einstellungen vorgenommen werden:
<ul>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naltatis I dont think we can use html here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it will look great..

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @naltatis

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should stick to Markdown. Lists are also possible there:

In the Zaptec portal (Installations -> Settings -> Power Management), the following settings must be configured for the Zaptec Go 2:

- Enable "Allow chargers to return to three-phase charging"</li>
- Set "Allowed switches before locking to single-phase charging" to the maximum of 20</li>
- Set "Switch from three-phase to single-phase charging" to 1 A</li>

@andig andig changed the title #21078 update doc for zaptec chargers. set capabilitier for go2 and p… Zaptec: split go2 and pro templates May 24, 2025
@andig andig marked this pull request as draft May 24, 2025 19:53
@andig andig added the devices Specific device support label May 25, 2025
@tbaehler tbaehler closed this Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devices Specific device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants