-
-
Notifications
You must be signed in to change notification settings - Fork 900
Zaptec: split go2 and pro templates #21357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…2 and pro to "rfid" and "1p3p" and add info how to change settings to let evcc control the phase switch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tbaehler - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
- name: password | ||
render: | | ||
type: zaptec | ||
id: {{ .id }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (bug_risk): Consider quoting ID and user fields for YAML safety
Quote these fields (e.g. id: "{{ .id }}") to prevent parsing errors with special characters.
Suggested implementation:
id: "{{ .id }}"
user: "{{ .user }}"
description: | ||
de: | | ||
Im Zaptec-Portal (Installationen -> Einstellungen -> Leistungsregelung) müssen für die Zaptec Go 2 folgende Einstellungen vorgenommen werden: | ||
<ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naltatis I dont think we can use html here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @naltatis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should stick to Markdown. Lists are also possible there:
In the Zaptec portal (Installations -> Settings -> Power Management), the following settings must be configured for the Zaptec Go 2:
- Enable "Allow chargers to return to three-phase charging"</li>
- Set "Allowed switches before locking to single-phase charging" to the maximum of 20</li>
- Set "Switch from three-phase to single-phase charging" to 1 A</li>
separate doc files to be able to add "1p3p" for go2 and pro.
add additional info how to configure zaptec go2 in portal to work with evcc