Ntfy: support auth tokens #25856
Open
Ntfy: support auth tokens #25856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andig
added
enhancement
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The
authTokenfield on theNtfystruct is currently unused after initialization; consider removing it or wiring it into behavior (e.g., for future re-auth or debugging) to avoid carrying sensitive data around unnecessarily. - When constructing the auth query parameter, you currently unconditionally
Set("auth", encoded)on the parsed URL; if users already provide anauthquery param manually, you might want to either detect and error or document/handle the precedence explicitly.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `authToken` field on the `Ntfy` struct is currently unused after initialization; consider removing it or wiring it into behavior (e.g., for future re-auth or debugging) to avoid carrying sensitive data around unnecessarily.
- When constructing the auth query parameter, you currently unconditionally `Set("auth", encoded)` on the parsed URL; if users already provide an `auth` query param manually, you might want to either detect and error or document/handle the precedence explicitly.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
griefie
changed the title
andig
reviewed
Dec 14, 2025
| if cc.AuthToken != "" { | ||
| bearer := "Bearer " + cc.AuthToken | ||
| encoded := base64.StdEncoding.EncodeToString([]byte(bearer)) | ||
| encoded = strings.TrimRight(encoded, "=") |
Member
There was a problem hiding this comment.
Should this be RawStdEncoding instead to omit the =?
andig
reviewed
Dec 14, 2025
| encoded := base64.StdEncoding.EncodeToString([]byte(bearer)) | ||
| encoded = strings.TrimRight(encoded, "=") | ||
|
|
||
| q := u.Query() |
andig
reviewed
Dec 14, 2025
|
|
||
| cc.URI = u.String() | ||
|
|
||
| log = log.Redact(cc.AuthToken, bearer, encoded) |
Member
There was a problem hiding this comment.
Why is bearer retracted? It's nowhere used?
andig
reviewed
Dec 14, 2025
| # uri: smtp://<user>:<password>@<host>:<port>/?fromAddress=<from>&toAddresses=<to> | ||
| # - type: ntfy | ||
| # uri: https://<host>/<topics> | ||
| # auth_token: <auth_token> |
Member
There was a problem hiding this comment.
Suggested change
| # auth_token: <auth_token> | |
| # authtoken: <auth_token> |
andig
reviewed
Dec 14, 2025
| # uri: smtp://<user>:<password>@<host>:<port>/?fromAddress=<from>&toAddresses=<to> | ||
| #- type: ntfy | ||
| # uri: https://<host>/<topics> | ||
| # auth_token: <auth_token> |
Member
There was a problem hiding this comment.
Suggested change
| # auth_token: <auth_token> | |
| # authtoken: <auth_token> |
andig
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional auth_token support for ntfy notifications:
once this is accepted i could make a PR for the docs