Publish batteryBuffered and batteryStart in site state (API/WebSocket/MQTT)#29288
Publish batteryBuffered and batteryStart in site state (API/WebSocket/MQTT)#29288
batteryBuffered and batteryStart in site state (API/WebSocket/MQTT)#29288Conversation
Agent-Logs-Url: https://github.com/evcc-io/evcc/sessions/25b97f33-7278-4636-88da-d942362fdc67 Co-authored-by: andig <184815+andig@users.noreply.github.com>
Agent-Logs-Url: https://github.com/evcc-io/evcc/sessions/25b97f33-7278-4636-88da-d942362fdc67 Co-authored-by: andig <184815+andig@users.noreply.github.com>
batteryBuffered and batteryStart in site state (API/WebSocket/MQTT)
|
@copilot Remove tests |
|
I checked the PR and the change looks aligned with what I had in my fork (batteryBuffered / batteryStart publication). |
|
@copilot Remove tests |
|
Copilot seems to be reluctant to remove the tests. |
|
Now that we removed the tests ofc. the linter complains and blocks the PR. |
|
Linter message says it all:
|
|
Follow-up fix is open:
This keeps the battery flag publication work unchanged while hopefully making the stack mergeable. |
|
I the follow up PR ive updated to latest main and let the unnecessary imports be removed. |
Co-authored-by: Mathias Walter <tolot27@users.noreply.github.com> Co-authored-by: VallahDieWaldfee <164005630+VallahDieWaldfee@users.noreply.github.com> Co-authored-by: Michael Geers <michael@geers.tv> Co-authored-by: Maschga <88616799+Maschga@users.noreply.github.com> Co-authored-by: andig <cpuidle@gmail.com> Co-authored-by: Alexandre JARDON <28548335+webalexeu@users.noreply.github.com> Co-authored-by: DiDu0815 <Dietmar.Dumke@dumke.de> Co-authored-by: Joni Lehtola <30690083+jonilehtola@users.noreply.github.com> Co-authored-by: RenatusRo <126881912+RenatusRo@users.noreply.github.com> Co-authored-by: andig <andi@evcc.io> Co-authored-by: CiNcH83 <daniel.bechter@gmail.com> Co-authored-by: docolli <78646938+docolli@users.noreply.github.com> Co-authored-by: Nazeeh Maxim Kanaaneh <nazih.dev@gmail.com> Co-authored-by: 0x3d13f <103030707+0x3d13f@users.noreply.github.com> Co-authored-by: triumfas <triumfas@gmail.com> Co-authored-by: Michael Heß <GrimmiMeloni@users.noreply.github.com> Co-authored-by: A. Veseli <adnan.veseli@gmail.com> Co-authored-by: Wim Haanstra <wim@haanstra.io> Co-authored-by: Vincent Bakker <mail@bakkerv.nl> Co-authored-by: Weblate (bot) <hosted@weblate.org>
|
Hi maintainers — small heads-up in case the recent “Run failed at startup” emails on our fork PR looked worrying: GitHub is still firing a separate workflow on No action needed from our side; just mentioning it in case it’s worth cleaning up on the repo when someone has a moment. 🙂 |
|
Merge / conflict update: #29456 merges current Follow-up on #29456: the branch was updated again to address @sourcery-ai review (shared YAML parse + safer |
Co-authored-by: Mathias Walter <tolot27@users.noreply.github.com> Co-authored-by: VallahDieWaldfee <164005630+VallahDieWaldfee@users.noreply.github.com> Co-authored-by: Michael Geers <michael@geers.tv> Co-authored-by: Maschga <88616799+Maschga@users.noreply.github.com> Co-authored-by: andig <cpuidle@gmail.com> Co-authored-by: Alexandre JARDON <28548335+webalexeu@users.noreply.github.com> Co-authored-by: DiDu0815 <Dietmar.Dumke@dumke.de> Co-authored-by: Joni Lehtola <30690083+jonilehtola@users.noreply.github.com> Co-authored-by: RenatusRo <126881912+RenatusRo@users.noreply.github.com> Co-authored-by: andig <andi@evcc.io> Co-authored-by: CiNcH83 <daniel.bechter@gmail.com> Co-authored-by: docolli <78646938+docolli@users.noreply.github.com> Co-authored-by: Nazeeh Maxim Kanaaneh <nazih.dev@gmail.com> Co-authored-by: 0x3d13f <103030707+0x3d13f@users.noreply.github.com> Co-authored-by: triumfas <triumfas@gmail.com> Co-authored-by: Michael Heß <GrimmiMeloni@users.noreply.github.com> Co-authored-by: A. Veseli <adnan.veseli@gmail.com> Co-authored-by: Wim Haanstra <wim@haanstra.io> Co-authored-by: Vincent Bakker <mail@bakkerv.nl> Co-authored-by: Weblate (bot) <hosted@weblate.org>
|
Hi maintainers,
→ #29462 (base: When CI is green there, it would be great if someone could merge #29462 into that branch first — then #29288 should merge cleanly into |
|
Hello @andig , |
External consumers could not reliably determine whether evcc currently allows battery-supported charging without duplicating threshold logic (
bufferSoc/bufferStartSoc) outside evcc. This change exposes the existing internal booleans directly in site state.State model updates
batteryBufferedbatteryStartcore/keys/site.go.Runtime publication
core/site.go:update(), publish the computed flags fromsitePower()on each update cycle./api/state, WebSocket events, and MQTT (through existing site key forwarding).Initial publication symmetry
core/site.go:prepare(), publish initial defaults for both flags (false) so retained/initial state is complete before first runtime update.Focused test coverage
core/site_test.gocoverage for:prepare()update()Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
192.168.1.1/tmp/go-build3560123150/b1496/service.test /tmp/go-build3560123150/b1496/service.test -test.testlogfile=/tmp/go-build3560123150/b1496/testlog.txt -test.paniconexit0 -test.timeout=10m0s /tmp/go-build3560123150/b1416/vet.cfg 0123150/b1236/_p-errorsas .cfg ux-amd64/pkg/tool/linux_amd64/vet -p theus/client_gol-unsafeptr=false t ux-amd64/pkg/too/tmp/go-build3560123150/b1323/vet.cfg -o l7Fm/dUpxlgeN7VYMG16kl7Fm t ux-amd64/pkg/tool/linux_amd64/compile -p github.com/eclip-o t ux-amd64/pkg/too-trimpath(packet block)224.0.0.251REDACTED, pid is -1(packet block)api.awattar.at/tmp/go-build3560123150/b1448/tariff.test /tmp/go-build3560123150/b1448/tariff.test -test.testlogfile=/tmp/go-build3560123150/b1448/testlog.txt -test.paniconexit0 -test.timeout=10m0s go1.26.0 -c=4 -nolocalimports -importcfg /tmp/go-build3560123150/b1383/importcfg -pack /home/REDACTED/work/evcc/evcc/messenger/config.go bV1zZTEAN7uQ(dns block)If you need me to access, download, or install something from one of these locations, you can either: