Skip to content

chore: pin dependencies (actions, docker, cli)#29460

Open
naltatis wants to merge 1 commit intomasterfrom
chore/pin_actions
Open

chore: pin dependencies (actions, docker, cli)#29460
naltatis wants to merge 1 commit intomasterfrom
chore/pin_actions

Conversation

@naltatis
Copy link
Copy Markdown
Member

@naltatis naltatis commented Apr 27, 2026

🔒 improve supply chain security, guard against dependency takeover
✅ improve OpenSSF scorecard https://scorecard.dev/viewer/?uri=github.com/evcc-io/evcc
🤖 dependabot will provide hash upgrade PRs

See also best practice recommendations:
https://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions
https://github.com/ossf/scorecard/blob/a1d03ef4c261559c5f6081fc91a74e18fd501eb6/docs/checks.md#pinned-dependencies

@naltatis naltatis added the infrastructure Basic functionality label Apr 27, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@naltatis naltatis requested a review from andig April 28, 2026 06:31
@andig
Copy link
Copy Markdown
Member

andig commented Apr 28, 2026

I'm absolutely not a fan of this. I want to keep the major versions:

Pin actions to a tag only if you trust the creator

This is specifically 3rd party. We trust GH.

@naltatis
Copy link
Copy Markdown
Member Author

I'm absolutely not a fan of this.

Also agree that this hurts readability. OpenSSFs recommendation is to pin all actions for full score. But they also differentiate severity between githubOwned and thirdParty actions ossf/scorecard#906

I'll move the GitHub owned back to tags but keep the 3rd party ones (highes risk) pinned.

@andig
Copy link
Copy Markdown
Member

andig commented Apr 28, 2026

Sounds like a good compromise. However, the problem is imho more how we chose and validate those. Pinning means they never get updated and tbo, the current version just means "it was there", not "it is secure and has been reviewed".

@naltatis
Copy link
Copy Markdown
Member Author

However, the problem is imho more how we chose and validate those.

This is the same as for go or npm deps. We are in charge of this.
Dependabot will issue upgrade PRs and also works with hashes. Pinning makes upgrade a deliberate action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Basic functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants