Indevolt battery control#31741
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new batterymode HTTP calls embed raw JSON in the query string without urlEncode, unlike the existing meter requests; consider using urlEncode for these config parameters to avoid issues with special characters.
- The template still references .minsoc and .maxsoc in the batterymode sequence despite the description mentioning their removal; please check whether these parameters are still intended and update the template or description accordingly.
- The help text for maxchargepower states a valid range of 50–3000 W, while the inline comment references an API validity range of 50–2400 W; aligning these ranges would prevent configuration confusion.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new batterymode HTTP calls embed raw JSON in the query string without urlEncode, unlike the existing meter requests; consider using urlEncode for these config parameters to avoid issues with special characters.
- The template still references .minsoc and .maxsoc in the batterymode sequence despite the description mentioning their removal; please check whether these parameters are still intended and update the template or description accordingly.
- The help text for maxchargepower states a valid range of 50–3000 W, while the inline comment references an API validity range of 50–2400 W; aligning these ranges would prevent configuration confusion.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
I have copied indevolt-battery.yaml into my Docker volume (/root/.evcc), but I'm running evcc in Docker on Synology/Portainer. How should the custom template be loaded? Should I change the container command or is there another recommended way? |
|
Nightly tested ● Indevolt is recognized as “controllable: Yes”. ● BYD reaches 100%. ● 3–3.5 kW PV surplus are fed in. ● Indevolt remains on standby (79% SoC). ● No commands appear in the debug log to switch to “Charge”. Only battery 2 soc and battery 2 power are read. |
|
That may be a misunderstanding. Charge means force-charging. Battery is still assumed to charge on its own during surplus in "normal" mode. |
Add battery control for indevolt devices.
Based on this discussion.
Suggested removal of minsoc/maxsoc implemented.
Re-opened because @ulrichreisinger offered to test on real hardware.
Suggested test:
PS: Closed PR did not update automatically #30957, so I created a new one