Tesla BLE: add odometer#31743
Draft
Optic00 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
odometersource to the tesla-ble vehicle template so the odometer shows up in the UI and session log.The backing proxy needs support for the
drive_stateendpoint: wimaha/TeslaBleHttpProxy#160. This PR should not be merged before that one.The odometer is read via a separate
endpoints=drive_staterequest, so all existing sources keep working unchanged against older proxy versions; on an old proxy only the odometer read fails, which surfaces as one error log line per vehicle identification, same as the other odometer-capable templates when their backend lacks the data.Scale is 1.60934 (miles to km), matching the
rangesource in the same template.Tested with
go test ./vehicle/ -run TestTemplatesand end-to-end against a live proxy implementing the new endpoint:Odometer()returns the car's real odometer reading in km (verified against the vehicle's displayed value),Soc()andStatus()unchanged.