fixed: battery minimum charging p_demand comes with bad side effects#61
Merged
andig merged 3 commits intoMar 15, 2026
Conversation
fix: added bianry variable array to inforce p_demand only until battery has reached s_max.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #59
Analysis: battery charging was forced to happen with at least p_demand if set in the request. Not meeting the constraint was loaded with a high penalty, even if the battery was fully charged. This created a weird behavior as the optimizer tried to delay full charging as long as possible in order to minimize the penalty.
Solution: introduced a second constraint that limits the charge demand to the remaining charge to reach s_max. Both constraints can be alternatively chosen by the optimizer through added binary variable which activates exclusively one of the constraints.
added test cases based on raised issues, updated one test case that now shows improved solution.