Implement 'limit' and 'skip' options in find()#113
Conversation
|
@mat02, that looks good to me, nice work! 🙂 Could you also extend the integration test suite here: Also, the linter check is failing, are you using VSCode or other IDE? With VSCode linter settings should be automatically taken into an account and applied on save. If you're open, it'd be nice to also extend Mongo shim and its tests: |
|
Thanks for the info. I'll look into integration tests and mongo shim next week. |
Might be that some local config takes precedence. in theory, you should get information about recommended plugins (ESlint, Prettier etc.) and by default autofix on save should happen, if it doesn't and the issue is on my side, I'm happy to make it smoother. It's also possible to run fix through CLI with |
|
Updated the Mongo shim and extended integration test suite. The linting issues were on me. I had the linter installed in a Docker container but was editing the files in a VS Code window connected directly to WSL... |
oskardudycz
left a comment
oskardudycz
left a comment
There was a problem hiding this comment.
Looks good, thanks @mat02! 🙂
Thank you for following up, glad that's not on my side 😅 |
|
@mat02, one thing to clarify, the current main code is on the next alpha, which is in the making, would you like me to cherry-pick your changes and release it to the regular version, or are you fine with just releasing it as part of the next alpha? |
|
If it's not a problem for you, it would be great to see this published more quickly, as I could progress with my project without having to stub in some custom build. |
Yup, it will be a regular publish. Just curious if you're fine with using alpha, or you'd prefer to retrofit it to the regular version? |
|
At this stage I'm perfectly fine with alpha as long as there are no drastic changes to the API or logic ;) |
Great, check the newly released |
2 participants
This PR introduces support for limit and skip options in the find() query method. These options allow more flexible querying by enabling pagination and result size control.