-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add docs generator #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| "dependencies": { | ||
| "isomorphic-fetch": "^2.2.1" | ||
| "isomorphic-fetch": "^2.2.1", | ||
| "typedoc": "^0.14.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't this be a devDep?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes.
| lib/ | ||
| dist/ | ||
|
|
||
| apidocs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore for committing makes sense. Should we make sure to include it in our files for npm though? How will these surface?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh cool!
|
Looks good, we should get this added to all of our stuff. Much easier to write docs in context of the code when possible. |
|
Can you make sure to remove any docs that this would replace as well. |
Adding docs.