Skip to content

Conversation

@jcreamer898
Copy link
Contributor

Adding docs.

"dependencies": {
"isomorphic-fetch": "^2.2.1"
"isomorphic-fetch": "^2.2.1",
"typedoc": "^0.14.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't this be a devDep?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes.

lib/
dist/

apidocs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore for committing makes sense. Should we make sure to include it in our files for npm though? How will these surface?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github pages?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh cool!

@kwelch-eb
Copy link
Contributor

Looks good, we should get this added to all of our stuff. Much easier to write docs in context of the code when possible.

@kwelch
Copy link
Contributor

kwelch commented Jan 29, 2019

Can you make sure to remove any docs that this would replace as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants