analog: Enable loading local config in hardware modules #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The analog module would construct a `SignallingCircuitSpan` without the `local-config` attribute, hence causing the hardware modules to discard the configuration.
lowlevl
force-pushed
the
fork/eventphone
branch
from
55526e4 to
cf31c18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a long-standing bug (13 years ago, see 33ba0e2) where the
analogmodule would construct a SignallingCircuitSpan without thelocal-configattribute, hence causing the hardware modules to be misconfigured.In example, it would produce an error as such from the
zapcardmodule:when the configuration indeed included an
offsetkey correctly set-up.This was caused by the configuration being loaded and immediately being discarded on here: https://github.com/lowlevl/yate/blob/master/modules/server/zapcard.cpp#L1711 because
local-configwasn't set.A little note on why this is submitted here and not in
yatevoip/yate:I at first considered proposing this patch to
yatevoip/yateI however noticed that the project was basically dead: there were no reviews or answers on patches or issues from the development team there from several years ago, I also noticed that the official tarball server went down some time ago (yate.null.ro), for which I sent a kind heads up email to the Null team that got left unanswered.This fork looks like the most promising in terms of features and bug fixes, and the fact that Yate is being used for congresses (where I learned about it, by the way, thanks !) makes me confident in that there could be at least minimal community-driven maintenance.
I would also get that you wanted to maintain your fork for the patches you made and not become a hub for the contributions for Yate !
Thanks.