Stage

[evereq]

PR

• Have you followed the contributing guidelines?
• Have you explained what your changes do, and why they add value?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

---

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ evereq
✅ syns2191
❌ dependabot[bot]
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch stage

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

Greptile Overview

Greptile Summary

This PR merges changes from the develop branch into stage-apps, bringing in error handling improvements and offline timer sync enhancements for the desktop timer application.

Key Changes:

• Introduced centralized ErrorMapping service to provide user-friendly, translated error messages for HTTP errors
• Refactored error handling across components to use the new notification service with duplicate prevention
• Enhanced offline timer synchronization logic to handle edge cases: timers started/stopped offline without IDs, and proper state reconciliation
• Added three new API methods (getTimeLogById, updateTimeLog, addTimeLog) to support complex offline sync scenarios
• Updated TypeORM from 0.3.24 to 0.3.27 across all packages
• Added comprehensive error message translations in 13 languages

Issues Found:

• Critical: UnauthorizedInterceptor has a broken navigation flow on line 40-44 where concatMap is called but not returned, preventing redirect to login page on 401 errors

Confidence Score: 2/5

• This PR contains a critical bug that will break user authentication flow when sessions expire
• Score reflects the critical logic error in UnauthorizedInterceptor that prevents proper redirect on 401 errors. The concatMap operator is created but never returned, making the navigation non-functional. This will break the authentication flow when tokens expire, leaving users unable to re-authenticate properly. The rest of the code appears sound with good improvements to error handling and offline sync.
• Critical attention needed for packages/desktop-ui-lib/src/lib/interceptors/unauthorized.interceptor.ts - the navigation logic is broken and must be fixed before merge

Important Files Changed

File Analysis

Filename	Score	Overview
packages/desktop-ui-lib/src/lib/interceptors/unauthorized.interceptor.ts	1/5	Added error mapping but introduced critical bug - navigation logic not returning concatMap result, breaking unauthorized redirect
packages/desktop-ui-lib/src/lib/services/error-mapping.service.ts	5/5	New service for centralizing HTTP error message mapping with translation support
packages/desktop-ui-lib/src/lib/time-tracker/time-tracker.service.ts	4/5	Added three new methods: getTimeLogById, updateTimeLog, and addTimeLog for offline sync improvements
packages/desktop-ui-lib/src/lib/offline-sync/concretes/sequence-queue.ts	4/5	Enhanced offline timer sync logic to handle edge cases: existing time logs, stopped timers without IDs, and proper state checking

Sequence Diagram

sequenceDiagram
    participant User
    participant TimeTrackerComponent
    participant TimeTrackerService
    participant HttpInterceptor
    participant ErrorMapping
    participant ToastrNotification
    participant SequenceQueue
    participant Backend

    User->>TimeTrackerComponent: Start/Stop Timer (Offline)
    TimeTrackerComponent->>TimeTrackerService: toggleApiStart/Stop()
    TimeTrackerService->>HttpInterceptor: HTTP Request
    
    alt Network Available
        HttpInterceptor->>Backend: Forward Request
        Backend-->>HttpInterceptor: Response
        HttpInterceptor-->>TimeTrackerService: Success
        TimeTrackerService-->>TimeTrackerComponent: Timer Data
    else Network Error
        HttpInterceptor->>ErrorMapping: mapErrorMessage(error)
        ErrorMapping-->>HttpInterceptor: Translated Error Message
        HttpInterceptor-->>TimeTrackerService: Throw Error
        TimeTrackerService->>ToastrNotification: error(message)
        ToastrNotification-->>User: Display Error Toast
        TimeTrackerComponent->>SequenceQueue: Queue Offline Timer
    end

    Note over SequenceQueue: When Back Online
    SequenceQueue->>TimeTrackerService: getTimeLogById(timelogId)
    TimeTrackerService->>Backend: GET /timesheet/time-log/:id
    Backend-->>TimeTrackerService: TimeLog Data
    
    alt Timer Started Offline (No TimeLog ID)
        SequenceQueue->>TimeTrackerService: addTimeLog(payload)
        TimeTrackerService->>Backend: POST /timesheet/time-log
        Backend-->>SequenceQueue: New TimeLog
    else Timer Stopped Offline (TimeLog Exists)
        SequenceQueue->>TimeTrackerService: updateTimeLog(id, payload)
        TimeTrackerService->>Backend: PUT /timesheet/time-log/:id
        Backend-->>SequenceQueue: Updated TimeLog
    end
    
    SequenceQueue->>ToastrNotification: success("Synced")
    ToastrNotification-->>User: Display Success Toast

Loading

Additional Comments (1)

1. packages/desktop-ui-lib/src/lib/interceptors/unauthorized.interceptor.ts, line 40-44 (link)

   logic: concatMap is called but its result is never used or returned, making the navigation non-functional

_{30 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}