Stage #9245
Stage #9245
Conversation
[FIX] Update environment variable for MCP deployment for both clusters and github actions
…-dependencies fix: desktop server missing some dependencies in runtime
* feat(ui): allow dual assignment of tasks to both teams and employees - Remove radio buttons for exclusive selection (employees OR teams) - Add both employee multi-select and team multi-select in add-task-dialog - Add employee multi-select to team-task-dialog component - Update onSave() methods to send both members and teams - Update initializeForm() to load both existing members and teams when editing This aligns the UI with the existing DB/API support for dual assignment. * fix(core): add guard clause for undefined mentionEmployeeIds - Add null check in TaskService.update before calling updateEntityMentions - Add guard clause in MentionService.updateEntityMentions for undefined input Prevents 'Cannot read properties of undefined (reading filter)' error when updating tasks without mentionEmployeeIds in the input.
…public HTTPS URL (#9244) * fix: add proper proxy headers and tust proxy to identify correct public HTTPS URL * Update k8s-manifest.mcp-auth.demo.yaml * Update k8s-manifest.mcp.demo.yaml --------- Co-authored-by: Ruslan Konviser <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Greptile OverviewGreptile SummaryThis PR merges multiple improvements into the stage branch, including infrastructure configuration updates, dependency additions, and a new task dual assignment feature. Key Changes:
PR Template Compliance: Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant TaskDialog
participant EmployeeService
participant TeamService
participant TaskService
participant MentionService
participant OAuth2Server
participant K8sIngress
Note over User,TaskDialog: Task Dual Assignment Flow
User->>TaskDialog: Create/Edit Task
TaskDialog->>EmployeeService: loadEmployees()
EmployeeService-->>TaskDialog: Employee List
TaskDialog->>TeamService: loadTeams()
TeamService-->>TaskDialog: Team List
User->>TaskDialog: Select Employees & Teams
TaskDialog->>TaskDialog: onSave()
TaskDialog->>TaskService: createTask({members, teams})
TaskService->>TaskService: Validate mentionEmployeeIds exists
alt mentionEmployeeIds provided
TaskService->>MentionService: updateEntityMentions(taskId, mentionIds)
MentionService-->>TaskService: Success
else mentionEmployeeIds not provided
TaskService->>TaskService: Skip mention sync
end
TaskService-->>TaskDialog: Task Created/Updated
TaskDialog-->>User: Success Message
Note over OAuth2Server,K8sIngress: OAuth Authorization Flow
User->>K8sIngress: POST /token (authorization_code)
K8sIngress->>K8sIngress: Set X-Forwarded-Proto headers
K8sIngress->>OAuth2Server: Forward request with headers
OAuth2Server->>OAuth2Server: handleAuthorizationCodeGrant()
OAuth2Server->>OAuth2Server: Validate params & client
alt Validation Success
OAuth2Server->>OAuth2Server: exchangeAuthorizationCode()
OAuth2Server->>OAuth2Server: generateTokenPair()
OAuth2Server->>OAuth2Server: Log success
OAuth2Server-->>K8sIngress: Return tokens
else Validation/Exchange Failure
OAuth2Server->>OAuth2Server: Log detailed error
OAuth2Server-->>K8sIngress: Return OAuth error
end
K8sIngress-->>User: Response
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "twing": "^5.0.2", | ||
| "underscore": "^1.13.3", | ||
| "undici": "^6.10.2", | ||
| "custom-electron-titlebar": "^4.2.8" | ||
| "custom-electron-titlebar": "^4.2.8", | ||
| "@as-integrations/express5": "^1.1.2" |
There was a problem hiding this comment.
A new dependency @as-integrations/express5 was added here, but the root yarn.lock still has no entry for it (rg "@as-integrations/express5" yarn.lock returns nothing). Our workflows install with yarn install --frozen-lockfile (e.g., .github/workflows/server-mcp-stage.yml), so the next CI run will fail with a lockfile mismatch as soon as it tries to build this package. Please add the resolved version to yarn.lock to keep frozen installs working.
Useful? React with 👍 / 👎.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 18 files
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/server-api/src/package.json">
<violation number="1" location="apps/server-api/src/package.json:214">
`@as-integrations/express5` requires Express 5 as a peer dependency, but this package.json does not install `express@^5`, leading to unmet peer dependencies and runtime import failures.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| "undici": "^6.10.2", | ||
| "custom-electron-titlebar": "^4.2.8" | ||
| "custom-electron-titlebar": "^4.2.8", | ||
| "@as-integrations/express5": "^1.1.2" |
There was a problem hiding this comment.
@as-integrations/express5 requires Express 5 as a peer dependency, but this package.json does not install express@^5, leading to unmet peer dependencies and runtime import failures.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/server-api/src/package.json, line 214:
<comment>`@as-integrations/express5` requires Express 5 as a peer dependency, but this package.json does not install `express@^5`, leading to unmet peer dependencies and runtime import failures.</comment>
<file context>
@@ -208,7 +210,8 @@
"undici": "^6.10.2",
- "custom-electron-titlebar": "^4.2.8"
+ "custom-electron-titlebar": "^4.2.8",
+ "@as-integrations/express5": "^1.1.2"
},
"optionalDependencies": {
</file context>
* Update k8s-manifest.mcp-auth.prod.yaml * Update k8s-manifest.mcp-auth.demo.yaml * Update k8s-manifest.mcp-auth.stage.yaml
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
Summary by cubic
Enable dual task assignment to both teams and employees, and stabilize MCP Auth deployments and OAuth2 token exchange with proper envs, proxy headers, and error handling. Also added missing runtime dependencies to prevent startup issues.
New Features
Bug Fixes
Written for commit 8654f96. Summary will update automatically on new commits.