Skip to content

Conversation

@evereq
Copy link
Member

@evereq evereq commented Dec 9, 2025

PR

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.



Summary by cubic

Adjusted Sentry error report embed position across apps to fix the bug report page layout. Added validation to the invoice pagination endpoint to correctly transform boolean query parameters for SQLite.

  • Bug Fixes

    • UI: Set .sentry-error-embed top to 30px in agent, desktop, desktop-timer, server, and server-api to fix overlay misplacement.
    • API: Added UseValidationPipe({ transform: true }) to GET /invoice/pagination to parse boolean filters correctly with SQLite.
  • Dependencies

    • Updated Electron to ^38.1.2 and electron-builder to 26.0.3 across apps and desktop packages.
    • Upgraded better-sqlite3 to 12.2.0 in core and desktop packages.

Written for commit c138c85. Summary will update automatically on new commits.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 9, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedrxjs@​7.8.29910010084100
Addedcamelcase@​6.3.010010010085100
Addedtypescript@​5.8.31001009010090
Addedprettier@​2.8.810010010098100

View full report

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedrxjs@​7.8.29910010084100
Addedcamelcase@​6.3.010010010085100
Addedtypescript@​5.8.31001009010090
Addedprettier@​2.8.810010010098100

View full report

@evereq evereq merged commit 750a986 into stage Dec 9, 2025
19 of 24 checks passed
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 9, 2025

Greptile Overview

Greptile Summary

This PR merges two bug fixes from develop into stage: a Sentry error widget positioning fix and an invoice pagination endpoint validation fix for SQLite compatibility.

  • Fixed Sentry error embed widget positioning across 5 desktop apps by adding CSS override to set top: 30px
  • Added @UseValidationPipe({ transform: true }) decorator to invoice pagination endpoint for proper boolean parameter transformation in SQLite environments

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk - merges tested bug fixes from develop branch
  • Score reflects two simple, targeted bug fixes that have already been merged to develop. The changes are minimal and focused. However, the PR template checkboxes are not filled out, which violates repository guidelines.
  • No files require special attention - all changes are straightforward bug fixes

Important Files Changed

File Analysis

Filename Score Overview
apps/desktop/src/assets/styles/_overrides.scss 5/5 Added CSS override to position Sentry error embed widget 30px from top
packages/core/src/lib/invoice/invoice.controller.ts 5/5 Added @UseValidationPipe with transform option to pagination endpoint for SQLite boolean compatibility

Sequence Diagram

sequenceDiagram
    participant Client
    participant InvoiceController
    participant ValidationPipe
    participant InvoiceService
    participant Database

    Note over Client,Database: Invoice Pagination Request Flow

    Client->>InvoiceController: GET /invoices/pagination?<params>
    InvoiceController->>ValidationPipe: Transform query params (transform: true)
    Note over ValidationPipe: Convert string booleans to actual booleans<br/>for SQLite compatibility
    ValidationPipe->>InvoiceController: Validated BaseQueryDTO
    InvoiceController->>InvoiceService: pagination(options)
    InvoiceService->>Database: Query with transformed boolean params
    Database-->>InvoiceService: Paginated results
    InvoiceService-->>InvoiceController: IPagination<IInvoice>
    InvoiceController-->>Client: Return paginated invoices
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants