Update desktop-timer-app-stage.yml (#9262)

[evereq]

• Update desktop-timer-app-stage.yml

• Update .github/workflows/desktop-timer-app-stage.yml

---

PR

• Have you followed the contributing guidelines?
• Have you explained what your changes do, and why they add value?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

---

---

Summary by cubic

Fix the Windows build in the stage CI for the Desktop Timer App by clearing unnecessary env vars and setting a controlled PATH. This avoids env size limit errors and makes the build reliable.

• Bug Fixes
  • Clear AZURE, ANDROID, JAVA, GO, Postgres, PHP, and STATS env vars during the build to reduce env size.
  • Set an explicit Windows PATH so the build uses the correct tools.

^{Written for commit 2b3f951. Summary will update automatically on new commits.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[greptile-apps]

Greptile Overview

Greptile Summary

Updated Windows build job to address environment variable size limits by clearing unused Azure, Android, Go, Java, PostgreSQL, and PHP environment variables, and explicitly setting the Path environment variable.

Key changes:

• Cleared 27 unused environment variables before the build step to reduce environment size
• Added hardcoded Path environment variable to ensure build tools remain accessible after clearing variables

Potential concerns:

• The hardcoded Path value is brittle and tied to the current runner image version - if the runner updates, paths may become invalid
• This appears to be a workaround for Windows environment variable size limitations rather than a root cause solution

Confidence Score: 4/5

• This PR is safe to merge with minimal risk - it addresses a specific build failure
• The changes are straightforward and solve a real Windows environment variable size issue. Score of 4 (not 5) due to the maintenance burden of hardcoding the Path variable, which may need updates when runner images change
• No files require special attention - this is a targeted fix for Windows build environment issues

Important Files Changed

File Analysis

Filename	Score	Overview
.github/workflows/desktop-timer-app-stage.yml	4/5	Added environment variable clearing and hardcoded Path to address Windows environment variable size limits in the Windows build job

Sequence Diagram

sequenceDiagram
    participant Trigger as Release Apps Stage Workflow
    participant Linux as Linux Build Job
    participant Mac as Mac Build Job
    participant Windows as Windows Build Job
    participant Env as Environment Variables
    participant Build as Build Process
    
    Trigger->>Linux: Trigger on workflow completion
    Trigger->>Mac: Trigger on workflow completion
    Trigger->>Windows: Trigger on workflow completion
    
    Note over Windows: Windows Build Process
    Windows->>Windows: Checkout repository
    Windows->>Windows: Install Node.js & dependencies
    Windows->>Windows: Bump version
    Windows->>Windows: Print env vars (debug)
    Windows->>Env: Clear Azure/Android/Go/Java/PG/PHP vars
    Env-->>Windows: Environment size reduced
    Windows->>Build: Execute yarn build:desktop-timer:windows:release:gh
    Build-->>Windows: Build artifacts
    Note over Windows: Hardcoded Path environment variable set

Loading

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

style: Hardcoding the Path environment variable makes this workflow brittle and tied to a specific runner version. If the runner image updates, this path will become stale and may break the build. Consider using the existing $PATH or $env:Path instead.

Prompt To Fix With AI

This is a comment left during a code review.
Path: .github/workflows/desktop-timer-app-stage.yml
Line: 263:263

Comment:
**style:** Hardcoding the `Path` environment variable makes this workflow brittle and tied to a specific runner version. If the runner image updates, this path will become stale and may break the build. Consider using the existing `$PATH` or `$env:Path` instead.

How can I resolve this? If you propose a fix, please make it concise.