Update desktop-timer-app-stage.yml

[evereq]

PR

• Have you followed the contributing guidelines?
• Have you explained what your changes do, and why they add value?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

---

---

Summary by cubic

Stabilizes the Desktop Timer staging workflow on Windows by sanitizing env vars and simplifying PATH to prevent npm lifecycle hooks and tool conflicts. Improves build reliability and reproducibility.

• Bug Fixes
  • Cleared npm_package_scripts_* vars and WARPBUILD_GH_JIT_TOKEN to avoid unintended pre/post script execution.
  • Reduced PATH to essential tools (Node, Git, Python, NSIS, WiX, CMake, PowerShell) to eliminate runner conflicts.
  • Kept the same build command: yarn build:desktop-timer:windows:release:gh.

^{Written for commit 1553f5e. Summary will update automatically on new commits.}

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (all 1 issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name=".github/workflows/desktop-timer-app-stage.yml">

<violation number="1" location=".github/workflows/desktop-timer-app-stage.yml:249">
P2: Trailing space after `=` sets the variable to a space character instead of clearing it. Remove the trailing space to properly clear this variable.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

[cubic-dev-ai]

P2: Trailing space after = sets the variable to a space character instead of clearing it. Remove the trailing space to properly clear this variable.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/desktop-timer-app-stage.yml, line 249:

<comment>Trailing space after `=` sets the variable to a space character instead of clearing it. Remove the trailing space to properly clear this variable.</comment>

<file context>
@@ -246,6 +246,48 @@ jobs:
           set PGROOT=
           set PGUSER=
           set PHPROOT=
+          set WARPBUILD_GH_JIT_TOKEN= 
+          set npm_package_scripts_build_package_plugins_post_docker=
+          set npm_package_scripts_build_package_plugins_post_prod=
</file context>

Suggested change

	set WARPBUILD_GH_JIT_TOKEN=
	set WARPBUILD_GH_JIT_TOKEN=

[greptile-apps]

Greptile Overview

Greptile Summary

Expanded environment variable cleanup in Windows build job by adding 42 npm_package_scripts_* variable clearances and significantly simplifying the PATH variable to work around Windows environment size limits.

• Added clearance for WARPBUILD_GH_JIT_TOKEN and 42 npm build script variables
• Reduced PATH from ~2000 characters to ~400 characters, keeping only essential directories (node, npm, git, python, system paths, NSIS, WiX, CMake)
• Minor style issue: trailing whitespace on line 290

Confidence Score: 4/5

• Safe to merge with minimal risk - addresses known Windows environment variable size limitation
• The changes are a practical workaround for Windows environment variable size limits in CI/CD. Clearing unused npm script variables and simplifying PATH won't affect the build process since the required tools remain accessible. Only minor style issue with trailing whitespace.
• No files require special attention - this is a straightforward infrastructure fix

Important Files Changed

File Analysis

Filename	Score	Overview
.github/workflows/desktop-timer-app-stage.yml	4/5	Added 42 npm script environment variable clearances and simplified PATH variable to reduce Windows environment size limits

Sequence Diagram

sequenceDiagram
    participant GHA as GitHub Actions
    participant Win as Windows Runner
    participant Env as Environment Variables
    participant Build as Build Process
    
    GHA->>Win: Trigger workflow on Release Apps Stage completion
    Win->>Win: Checkout repository
    Win->>Win: Setup Node.js 20.18.1
    Win->>Win: Install dependencies (npm, node-gyp, yarn)
    Win->>Win: Bump desktop timer app version
    Win->>Env: Print environment variables and sizes
    Win->>Env: Print PATH variable value
    Win->>Env: Clear Azure, Android, Java, Go, Postgres, PHP env vars
    Win->>Env: Clear WARPBUILD_GH_JIT_TOKEN
    Win->>Env: Clear 42 npm_package_scripts_* variables
    Win->>Env: Simplify PATH to essential directories only
    Env->>Build: Reduced environment size
    Build->>Build: Execute yarn build:desktop-timer:windows:release:gh
    Build->>GHA: Build artifacts with Sentry & DigitalOcean config

Loading

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

style: trailing whitespace after =

Suggested change

	set npm_package_scripts_build_gauzy_api_server_linux_release_gh=
	set npm_package_scripts_build_gauzy_api_server_linux_release_gh=

Prompt To Fix With AI

This is a comment left during a code review.
Path: .github/workflows/desktop-timer-app-stage.yml
Line: 290:290

Comment:
**style:** trailing whitespace after `=`

```suggestion
          set npm_package_scripts_build_gauzy_api_server_linux_release_gh=
```

How can I resolve this? If you propose a fix, please make it concise.