Stage #9270

evereq · 2025-12-18T21:42:39Z

PR

Have you followed the contributing guidelines?
Have you explained what your changes do, and why they add value?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Summary by cubic

Upgrade CI and Docker builds to Node.js 22 and npm 10, and fix Windows builds with VS 2022 toolchain, node-gyp Python config, and path setup. Updates workflows, Dockerfiles, and scripts to use ts-node, nx, and cross-env for consistent cross‑platform builds.

Bug Fixes
- Reliable Windows builds: install VS 2022 Build Tools, set GYP_MSVS_VERSION, configure npm Python for node-gyp, and add Yarn/Node/npm-global/local bin to PATH.
- Added tool version diagnostics and command path checks in workflows.
- Simplified desktop-timer stage workflow by removing env var hacks and using proper PATH setup.
Dependencies
- Node.js 22.21.1 and npm 10.9.4 across GitHub Actions; ts-node 10.9.2 and nx 20.8.0 installed globally in workflows.
- Dockerfiles install ts-node globally (and yarn where missing).
- Added/updated devDeps: ts-node and cross-env in multiple packages; scripts call ts-node directly and use cross-env.
- Replaced “yarn nx …” with “nx …” in project commands.

^{Written for commit 4c3c829. Summary will update automatically on new commits.}

…ps builds

coderabbitai · 2025-12-18T21:42:45Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cubic-dev-ai

No issues found across 27 files

greptile-apps · 2025-12-18T21:47:51Z

Greptile Summary

This PR upgrades the build infrastructure from Node.js v20.18.1 to v22.21.1 and npm v9 to v10.9.4, while adding global installations of [email protected] and [email protected] to resolve Windows build issues.

Major Changes

Node.js upgrade: v20.18.1 → v22.21.1 across all CI/CD workflows and Dockerfiles
npm upgrade: v9 → v10.9.4 for better compatibility
Global tool installation: Added ts-node and nx globally in CI environments and Dockerfiles
Direct tool execution: Removed yarn prefix from commands in project.json files to call tools directly
Windows build improvements: Enhanced PATH configuration to include local node_modules/.bin, npm global bin, and tool directories for proper binary resolution
Package dependencies: Added ts-node, cross-env, and concurrently to various package.json files as devDependencies

Issues Found

Indentation inconsistency: Two Dockerfiles (.deploy/mcp-auth/Dockerfile:109 and .deploy/mcp/Dockerfile:153) use tab indentation instead of spaces
Branch configuration: .github/workflows/windows.yml triggers on win branch instead of standard branches like develop

Notes

The PR template checklist is not completed - boxes are unchecked and no explanation of changes is provided in the PR description

Confidence Score: 4/5

This PR is safe to merge with minor formatting fixes needed
The changes are infrastructure upgrades that follow a consistent pattern across 27 files. The Node.js and npm version updates align with the commit messages about fixing Windows builds. Minor syntax issues (tab vs space indentation) in two Dockerfiles need correction, and the branch trigger configuration in windows.yml should be verified. The PR template requirements are not met, but the technical changes are sound.
.deploy/mcp-auth/Dockerfile and .deploy/mcp/Dockerfile need indentation fixes; verify .github/workflows/windows.yml branch configuration is intentional

Important Files Changed

Filename	Overview
.deploy/mcp-auth/Dockerfile	Added `ts-node` and `yarn` global installation; inconsistent indentation on line 109 (tab vs spaces)
.deploy/mcp/Dockerfile	Added `ts-node` and `yarn` global installation; inconsistent indentation on line 153 (tab vs spaces)
.github/workflows/windows.yml	Updated Node to v22.21.1, npm to v10.9.4; added `ts-node` and `nx`; changed to `win` branch trigger; improved PATH configuration
packages/ui-config/project.json	Removed `yarn` prefix from commands to call `ts-node` and `nx` directly
packages/core/project.json	Removed `yarn` prefix from `ts-node` command in serve target
.github/workflows/desktop-timer-app-stage.yml	Updated Node to v22.21.1, npm to v10.9.4; added global `ts-node` and `nx` packages; improved Windows build with PATH fixes

Sequence Diagram

sequenceDiagram
    participant CI as CI/CD Pipeline
    participant Setup as Environment Setup
    participant Deps as Dependency Management
    participant Build as Build Process
    
    Note over CI,Build: Updated Build Infrastructure
    
    CI->>Setup: Checkout code
    Setup->>Setup: Install Node.js v22.21.1 (was v20.18.1)
    Setup->>Setup: Install npm v10.9.4 (was v9)
    Setup->>Setup: Install Visual Studio 2022 (Windows)
    
    Note over Setup: Global Package Installation
    Setup->>Setup: Install [email protected]
    Setup->>Setup: Install [email protected] (NEW)
    Setup->>Setup: Install [email protected] (NEW)
    
    Note over Setup: Windows-specific PATH Configuration
    Setup->>Setup: Configure Python for node-gyp
    Setup->>Setup: Add local node_modules/.bin to PATH
    Setup->>Setup: Add npm global bin to PATH
    Setup->>Setup: Add Yarn/Node paths to PATH
    
    Setup->>Deps: Install Yarn dependencies
    Deps->>Deps: yarn install --frozen-lockfile
    
    Note over Deps: Package.json Updates
    Deps->>Deps: Include cross-env in packages
    Deps->>Deps: Include ts-node in packages
    Deps->>Deps: Include concurrently in e2e
    
    Deps->>Build: Execute build commands
    
    Note over Build: Direct Tool Execution
    Build->>Build: Execute ts-node directly (not via yarn)
    Build->>Build: Execute nx directly (not via yarn)
    Build->>Build: Execute cross-env directly
    
    Build->>CI: Build artifacts ready

greptile-apps

_{27 files reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2025-12-18T21:47:49Z

.deploy/mcp-auth/Dockerfile


 RUN apk add --no-cache python3 python3-dev py3-pip py3-setuptools build-base gcc g++ make autoconf automake git \
    && npm install --quiet [email protected] -g \
+	&& npm install yarn -g --force \


syntax: Line uses tab indentation while surrounding lines use spaces

Suggested change

&& npm install yarn -g --force \

&& npm install yarn -g --force \

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Prompt To Fix With AI

This is a comment left during a code review. Path: .deploy/mcp-auth/Dockerfile Line: 109:109 Comment: **syntax:** Line uses tab indentation while surrounding lines use spaces ```suggestion && npm install yarn -g --force \ ``` Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2025-12-18T21:47:49Z

.deploy/mcp/Dockerfile


 RUN apk add --no-cache python3 python3-dev py3-pip py3-setuptools build-base gcc g++ make autoconf automake git \
    && npm install --quiet [email protected] -g \
+	&& npm install yarn -g --force \


syntax: Line uses tab indentation while surrounding lines use spaces

Suggested change

&& npm install yarn -g --force \

&& npm install yarn -g --force \

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Prompt To Fix With AI

This is a comment left during a code review. Path: .deploy/mcp/Dockerfile Line: 153:153 Comment: **syntax:** Line uses tab indentation while surrounding lines use spaces ```suggestion && npm install yarn -g --force \ ``` Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2025-12-18T21:47:50Z

.github/workflows/windows.yml

 on:
  push:
-    branches: [develop, temp]
+    branches: [win]


style: Check that triggering on the win branch is intentional - other workflows use develop or main

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Prompt To Fix With AI

This is a comment left during a code review. Path: .github/workflows/windows.yml Line: 5:5 Comment: **style:** Check that triggering on the `win` branch is intentional - other workflows use `develop` or `main` Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! How can I resolve this? If you propose a fix, please make it concise.

evereq added 11 commits December 18, 2025 13:25

Update Node.js and NPM versions in workflow

abf276d

Update windows.yml

4c81fdb

fix: build Windows

d05f9d1

fix: Windows builds

c66a655

fix: windows builds

7ebd45c

chore: fix Windows builds

64fdfdf

fix: windows builds

d5e76ee

fix: builds

9f438dd

chore: add ts-node to some packages

e1555da

chore: more fixes for builds

12bc806

chore: fixes for Windows builds and update Node to v22 for desktop ap…

4c3c829

…ps builds

evereq merged commit baa0aee into stage Dec 18, 2025
22 of 24 checks passed

evereq temporarily deployed to demo December 18, 2025 21:44 — with GitHub Actions Inactive

cubic-dev-ai bot reviewed Dec 18, 2025

View reviewed changes

greptile-apps bot reviewed Dec 18, 2025

View reviewed changes

evereq temporarily deployed to stage December 18, 2025 21:55 — with GitHub Actions Inactive

evereq temporarily deployed to demo December 18, 2025 22:01 — with GitHub Actions Inactive

evereq temporarily deployed to stage December 18, 2025 22:02 — with GitHub Actions Inactive

evereq temporarily deployed to demo December 19, 2025 01:03 — with GitHub Actions Inactive

evereq temporarily deployed to stage December 19, 2025 01:08 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Stage #9270

Stage #9270

Uh oh!

evereq commented Dec 18, 2025 •

edited by cubic-dev-ai bot

Loading

Uh oh!

coderabbitai bot commented Dec 18, 2025

Review skipped

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

greptile-apps bot commented Dec 18, 2025

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Dec 18, 2025

Uh oh!

greptile-apps bot Dec 18, 2025

Uh oh!

greptile-apps bot Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	&& npm install yarn -g --force \
	&& npm install yarn -g --force \

Stage #9270

Stage #9270

Uh oh!

Conversation

evereq commented Dec 18, 2025 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR

Summary by cubic

Uh oh!

coderabbitai bot commented Dec 18, 2025

Review skipped

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Dec 18, 2025

Greptile Summary

Major Changes

Issues Found

Notes

Confidence Score: 4/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

evereq commented Dec 18, 2025 •

edited by cubic-dev-ai bot

Loading