Stage

[evereq]

PR

• Have you followed the contributing guidelines?
• Have you explained what your changes do, and why they add value?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

---

---

Summary by cubic

Stabilizes builds across platforms (including Windows) and upgrades CI to Node 22, while improving the desktop timer with better auth handling, task syncing, and clearer tray/always‑on UI.

• New Features

  • Tray icon turns gray when the timer is idle.
  • Persist selected task from the task table and update task status while tracking.
  • Always‑on widget shows an offline indicator and uses a slimmer layout.

• Bug Fixes

  • Fix Windows builds and native module compilation in MCP/API Docker images by adding required build tools and correct rebuild steps.
  • Handle offline/unauthenticated states on agent startup; queue processing no longer errors on 401.
  • CI: upgrade to Node 22.21.1 and npm 10.9.4; install node-gyp, ts-node, and nx globally; add a dedicated Windows workflow.

• Dependencies

  • Add ts-node and cross-env to multiple packages; switch scripts to ts-node/cross-env.
  • Bump @modelcontextprotocol/sdk to 1.24.0.
  • Minor cspell dictionary updates.

^{Written for commit baa0aee. Summary will update automatically on new commits.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch stage

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

To fix the problem, the explicit permissions: block should be added at either the root of the workflow or at the job level to restrict the permissions of the GITHUB_TOKEN to the minimum required. Since nothing in the shown steps appears to require write access to the repository (most actions use local context or secrets for publishing), setting permissions: contents: read is a safe minimal configuration. If, in the future, steps require write permissions for issues, pull requests, or packages, those can be added incrementally. The fix should be done by inserting the line permissions:\n contents: read after the workflow name: (line 1), before on: (line 3), so that the permission applies to the entire workflow.

---

[cla-assistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ evereq
✅ syns2191
✅ RolandM99
❌ dependabot[bot]
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[cla-assistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ evereq
✅ RolandM99
✅ syns2191
❌ dependabot[bot]
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[greptile-apps]

Greptile Summary

This PR merges changes from the develop branch focused on Windows build improvements and desktop timer app enhancements. The changes update Node.js to v22.21.1, add build tooling (ts-node, cross-env), and implement task/project tracking for the desktop timer agent.

Major Changes:

• Windows Build Infrastructure: New Windows workflow with Visual Studio 2022, enhanced node-gyp configuration, and improved PATH management for building native modules
• Node.js & Tooling Updates: Upgraded to Node.js v22.21.1, NPM v10.9.4, added ts-node and nx as global packages across all workflows
• Docker Build Enhancements: Added build dependencies (node-gyp, ts-node) and switched from direct npm rebuild to manual postinstall process
• Task/Project Tracking: Desktop timer agent now tracks selected tasks/projects and automatically updates task status to IN_PROGRESS when timer starts
• Enhanced Authentication: Added server-side authentication validation with online status check and improved offline handling
• Error Handling: Improved error handling in activity push workers with nested try-catch blocks to prevent queue failures

Issues Found:

• updateProject function accepts but doesn't use organizationId parameter (violates custom rule ee186c2f-1a72-402b-901d-06d0cf08a36e)
• IPC handler uses nullish coalescing with string "null" instead of actual null values
• Failed authentication check doesn't display auth window for re-authentication
• Multi-tenant task status caching issue where statusProgress isn't keyed by tenant/organization
• Automatic task status updates to IN_PROGRESS may override legitimate states without user control

Confidence Score: 3/5

• This PR has several logical issues that need addressing before merge, particularly around null handling and multi-tenant data consistency
• The PR includes extensive build infrastructure improvements that are well-implemented, but the task tracking feature has 4 logical bugs: unused parameters, incorrect null handling, incomplete error flow, and potential multi-tenant data corruption. The build and dependency changes are safe, but the agent code needs fixes
• Pay close attention to apps/agent/src/main/util.ts, apps/agent/src/main/init/ipcMain.ts, apps/agent/src/main/auth.ts, and apps/agent/src/main/api.ts for the logic issues identified

Important Files Changed

Filename	Overview
apps/agent/src/main/util.ts	Added project configuration management functions but updateProject doesn't use the organizationId parameter it accepts
apps/agent/src/main/init/ipcMain.ts	Added TASK_SELECTED IPC handler but incorrectly uses nullish coalescing with string "null" instead of actual null
apps/agent/src/main/auth.ts	Enhanced authentication check with online status and server validation, but failed auth check doesn't display auth window for re-authentication
apps/agent/src/main/api.ts	Added task status management and project config integration, but statusProgress caching may cause issues in multi-tenant scenarios
apps/agent/src/main/workers/push-activities.ts	Improved error handling with nested try-catch blocks and added automatic task status updates to IN_PROGRESS when timer starts
.github/workflows/windows.yml	New Windows-specific build workflow with Visual Studio 2022 setup, node-gyp configuration, and PATH management for building desktop apps
.github/workflows/desktop-timer-app-stage.yml	Updated Node.js to v22.21.1, NPM to v10.9.4, added ts-node and nx global packages, improved Windows build tooling with VS 2022
packages/desktop-ui-lib/src/lib/time-tracker/task-table/table/task-table.component.ts	Added IPC event handler to notify Electron main process when task is selected from table for project/task tracking

Sequence Diagram

sequenceDiagram
    participant UI as Desktop UI (Task Table)
    participant IPC as IPC Main Handler
    participant Store as LocalStore
    participant Timer as Timer/Worker
    participant API as API Service
    participant Server as Gauzy Server

    Note over UI,Server: Task Selection Flow
    UI->>IPC: TASK_SELECTED event (taskId, projectId, organizationId)
    IPC->>Store: updateProject(projectId, taskId, organizationId)
    Note over Store: Stores project config locally

    Note over UI,Server: Timer Start Flow
    Timer->>API: getTimeToggleParams()
    API->>Store: getProjectConfig()
    Store-->>API: projectId, taskId, organizationContactId
    API->>Server: POST /api/time-log/start (with project/task)
    Server-->>API: Timer started

    Note over UI,Server: Activity Sync & Task Status Update
    Timer->>Timer: syncTimer(job)
    Timer->>Timer: updateTaskStatus()
    Timer->>API: getTask(taskId)
    API->>Server: GET /api/tasks/:taskId
    Server-->>API: Task details
    
    alt Task status is not IN_PROGRESS
        Timer->>API: getTasksStatuses()
        API->>Server: GET /api/task-statuses
        Server-->>API: Status list
        Note over API: Cache statusProgress
        Timer->>API: updateTaskStatus(taskId)
        API->>Server: PUT /api/tasks/:taskId (status=IN_PROGRESS)
        Server-->>API: Updated task
    end

    Note over UI,Server: Activity Push with Project Context
    Timer->>API: createTimeSlotPayload()
    API->>Store: getProjectConfig()
    Store-->>API: projectId, taskId, organizationContactId
    API->>Server: POST /api/time-slot (with project/task context)
    Server-->>API: TimeSlot created

    Note over UI,Server: Authentication Check
    Timer->>API: checkUserAuthentication()
    API->>Server: GET /api/auth/authenticated
    alt Online & Authenticated
        Server-->>API: Authenticated
        API-->>Timer: Continue operations
    else Offline
        Note over Timer: Skip server check, continue
    else Not Authenticated
        API-->>Timer: Show auth window
    end

Loading

[greptile-apps]

_{39 files reviewed, 5 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

logic: organizationId parameter is accepted but never used in the function body

Suggested change

	export function updateProject(project: {
	projectId: string;
	taskId: string;
	organizationId: string;
	}) {
	LocalStore.updateConfigProject({
	projectId: project.projectId,
	taskId: project.taskId
	});
	export function updateProject(project: {
	projectId: string;
	taskId: string;
	organizationId: string;
	}) {
	LocalStore.updateConfigProject({
	projectId: project.projectId,
	taskId: project.taskId,
	organizationContactId: project.organizationContactId
	});
	}

Context Used: Context from dashboard - Remove unused props from component interfaces in TypeScript, or add comments explaining their purpos... (source)

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/agent/src/main/util.ts
Line: 133:141

Comment:
**logic:** `organizationId` parameter is accepted but never used in the function body

```suggestion
export function updateProject(project: {
	projectId: string;
	taskId: string;
	organizationId: string;
}) {
	LocalStore.updateConfigProject({
		projectId: project.projectId,
		taskId: project.taskId,
		organizationContactId: project.organizationContactId
	});
}
```

**Context Used:** Context from `dashboard` - Remove unused props from component interfaces in TypeScript, or add comments explaining their purpos... ([source](https://app.greptile.com/review/custom-context?memory=ee186c2f-1a72-402b-901d-06d0cf08a36e))

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

logic: Passing null as string will store the string "null" instead of actual null value. Use JavaScript null directly

Suggested change

	ipcMain.handle('TASK_SELECTED', (_, data: { taskId: string; organizationId: string; projectId: string }) => {
	updateProject({
	taskId: data.taskId ?? null,
	organizationId: data.organizationId ?? null,
	projectId: data.projectId ?? null
	});
	return true;
	ipcMain.handle('TASK_SELECTED', (_, data: { taskId: string; organizationId: string; projectId: string }) => {
	updateProject({
	taskId: data.taskId || null,
	organizationId: data.organizationId || null,
	projectId: data.projectId || null
	});
	return true;
	});

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/agent/src/main/init/ipcMain.ts
Line: 324:330

Comment:
**logic:** Passing `null` as string will store the string "null" instead of actual null value. Use JavaScript null directly

```suggestion
	ipcMain.handle('TASK_SELECTED', (_, data: { taskId: string; organizationId: string; projectId: string }) => {
		updateProject({
			taskId: data.taskId || null,
			organizationId: data.organizationId || null,
			projectId: data.projectId || null
		});
		return true;
	});
```

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

logic: If authentication check fails, the function returns false but doesn't show the auth window to the user, leaving them in an unauthenticated state with no way to re-authenticate. Should the auth window be displayed when the authentication check fails, similar to when no token exists?

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/agent/src/main/auth.ts
Line: 40:43

Comment:
**logic:** If authentication check fails, the function returns false but doesn't show the auth window to the user, leaving them in an unauthenticated state with no way to re-authenticate. Should the auth window be displayed when the authentication check fails, similar to when no token exists?

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

logic: Using a cached instance field (this.statusProgress) for task statuses across different tenants/organizations could cause data inconsistency in multi-tenant scenarios. Should the statusProgress cache be keyed by tenantId/organizationId to handle multi-tenant scenarios correctly?

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/agent/src/main/api.ts
Line: 404:416

Comment:
**logic:** Using a cached instance field (`this.statusProgress`) for task statuses across different tenants/organizations could cause data inconsistency in multi-tenant scenarios. Should the statusProgress cache be keyed by tenantId/organizationId to handle multi-tenant scenarios correctly?

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

style: Consider making automatic task status update to IN_PROGRESS configurable, as it might override legitimate task states without user consent

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/agent/src/main/workers/push-activities.ts
Line: 282:306

Comment:
**style:** Consider making automatic task status update to IN_PROGRESS configurable, as it might override legitimate task states without user consent

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

[cubic-dev-ai]

2 issues found across 40 files

Prompt for AI agents (all 2 issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/desktop-ui-lib/src/lib/always-on/always-on.component.scss">

<violation number="1" location="packages/desktop-ui-lib/src/lib/always-on/always-on.component.scss:149">
P1: Missing `position: relative` on parent container. The `.current-session` and `.today-time` elements have `position: absolute` but their parent `.time-display` lacks `position: relative`, causing them to position relative to an unintended ancestor instead of their container.</violation>
</file>

<file name="apps/agent/src/main/api.ts">

<violation number="1" location="apps/agent/src/main/api.ts:408">
P1: The `statusProgress` cache doesn&#39;t account for different `tenantId`/`organizationId` combinations. Since `ApiService` is a singleton, switching organizations will reuse the cached status from a previous organization. Consider keying the cache by `tenantId` and `organizationId`, or invalidating the cache when these values change.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

[cubic-dev-ai]

P1: Missing position: relative on parent container. The .current-session and .today-time elements have position: absolute but their parent .time-display lacks position: relative, causing them to position relative to an unintended ancestor instead of their container.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/desktop-ui-lib/src/lib/always-on/always-on.component.scss, line 149:

<comment>Missing `position: relative` on parent container. The `.current-session` and `.today-time` elements have `position: absolute` but their parent `.time-display` lacks `position: relative`, causing them to position relative to an unintended ancestor instead of their container.</comment>

<file context>
@@ -143,15 +143,20 @@ button {
+		font-size: 16px;
 		font-weight: bold;
 		line-height: 1.2;
+		position: absolute;
+		top: 7px;
 	}
</file context>

[cubic-dev-ai]

P1: The statusProgress cache doesn't account for different tenantId/organizationId combinations. Since ApiService is a singleton, switching organizations will reuse the cached status from a previous organization. Consider keying the cache by tenantId and organizationId, or invalidating the cache when these values change.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/agent/src/main/api.ts, line 408:

<comment>The `statusProgress` cache doesn&#39;t account for different `tenantId`/`organizationId` combinations. Since `ApiService` is a singleton, switching organizations will reuse the cached status from a previous organization. Consider keying the cache by `tenantId` and `organizationId`, or invalidating the cache when these values change.</comment>

<file context>
@@ -359,6 +368,54 @@ export class ApiService {
+		tenantId,
+		organizationId
+	}: { tenantId: string, organizationId: string }): Promise&lt;void&gt; {
+		if (this.statusProgress) {
+			return;
+		}
</file context>