Stage #9279
Stage #9279
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
5 issues found across 20 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/server-api/src/package.json">
<violation number="1" location="apps/server-api/src/package.json:89">
P2: Removing explicit architecture specification drops arm64 build support for Linux targets. The `artifactName` template still uses `${arch}`, suggesting multi-arch builds are expected. Consider restoring explicit arch arrays for targets that previously supported arm64 (deb, tar.gz, rpm, AppImage).</violation>
</file>
<file name=".github/workflows/agent-stage.yml">
<violation number="1" location=".github/workflows/agent-stage.yml:138">
P2: Environment variables `DESKTOP_AGENT_APP_REPO_NAME` and `DESKTOP_AGENT_APP_REPO_OWNER` won't be consumed by the script. The `agent()` function in `bump-version-electron.js` reads `AGENT_APP_REPO_NAME` and `AGENT_APP_REPO_OWNER` (without the `DESKTOP_` prefix). Consider using the correct variable names.</violation>
</file>
<file name="apps/desktop-timer/src/package.json">
<violation number="1" location="apps/desktop-timer/src/package.json:82">
P2: Removing explicit `arch` configuration drops ARM64 Windows support. Unlike mac (which still specifies both x64 and arm64), Windows will now only build for the default architecture. If ARM64 support is intentionally being dropped, consider documenting this breaking change.</violation>
</file>
<file name="apps/server-mcp/src/package.json">
<violation number="1" location="apps/server-mcp/src/package.json:81">
P2: Removing explicit architecture specification for Windows target will cause builds to only produce artifacts for the build machine's architecture. This removes ARM64 support that was previously configured. Consider keeping the explicit arch specification if multi-architecture builds are needed.</violation>
<violation number="2" location="apps/server-mcp/src/package.json:89">
P2: Simplifying Linux targets to string array removes explicit ARM64 architecture support. Builds will only produce artifacts for the build machine's architecture. Consider restoring arch specifications if multi-architecture Linux builds are required.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| "arm64" | ||
| ] | ||
| } | ||
| "deb", |
There was a problem hiding this comment.
P2: Removing explicit architecture specification drops arm64 build support for Linux targets. The artifactName template still uses ${arch}, suggesting multi-arch builds are expected. Consider restoring explicit arch arrays for targets that previously supported arm64 (deb, tar.gz, rpm, AppImage).
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/server-api/src/package.json, line 89:
<comment>Removing explicit architecture specification drops arm64 build support for Linux targets. The `artifactName` template still uses `${arch}`, suggesting multi-arch builds are expected. Consider restoring explicit arch arrays for targets that previously supported arm64 (deb, tar.gz, rpm, AppImage).</comment>
<file context>
@@ -78,53 +78,19 @@
- "arm64"
- ]
- }
+ "deb",
+ "snap",
+ "tar.gz",
</file context>
| PROJECT_REPO: 'https://github.com/ever-co/ever-gauzy.git' | ||
| DESKTOP_AGENT_APP_NAME: 'ever-gauzy-agent' | ||
| DESKTOP_AGENT_APP_NAME: 'gauzy-agent' | ||
| DESKTOP_AGENT_APP_REPO_NAME: 'ever-gauzy-agent' |
There was a problem hiding this comment.
P2: Environment variables DESKTOP_AGENT_APP_REPO_NAME and DESKTOP_AGENT_APP_REPO_OWNER won't be consumed by the script. The agent() function in bump-version-electron.js reads AGENT_APP_REPO_NAME and AGENT_APP_REPO_OWNER (without the DESKTOP_ prefix). Consider using the correct variable names.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/agent-stage.yml, line 138:
<comment>Environment variables `DESKTOP_AGENT_APP_REPO_NAME` and `DESKTOP_AGENT_APP_REPO_OWNER` won't be consumed by the script. The `agent()` function in `bump-version-electron.js` reads `AGENT_APP_REPO_NAME` and `AGENT_APP_REPO_OWNER` (without the `DESKTOP_` prefix). Consider using the correct variable names.</comment>
<file context>
@@ -132,9 +134,11 @@ jobs:
PROJECT_REPO: 'https://github.com/ever-co/ever-gauzy.git'
- DESKTOP_AGENT_APP_NAME: 'ever-gauzy-agent'
+ DESKTOP_AGENT_APP_NAME: 'gauzy-agent'
+ DESKTOP_AGENT_APP_REPO_NAME: 'ever-gauzy-agent'
+ DESKTOP_AGENT_APP_REPO_OWNER: 'ever-co'
COMPANY_SITE_LINK: 'https://gauzy.co'
</file context>
| DESKTOP_AGENT_APP_REPO_NAME: 'ever-gauzy-agent' | |
| AGENT_APP_REPO_NAME: 'ever-gauzy-agent' |
| ] | ||
| } | ||
| ], | ||
| "target": "nsis", |
There was a problem hiding this comment.
P2: Removing explicit arch configuration drops ARM64 Windows support. Unlike mac (which still specifies both x64 and arm64), Windows will now only build for the default architecture. If ARM64 support is intentionally being dropped, consider documenting this breaking change.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/desktop-timer/src/package.json, line 82:
<comment>Removing explicit `arch` configuration drops ARM64 Windows support. Unlike mac (which still specifies both x64 and arm64), Windows will now only build for the default architecture. If ARM64 support is intentionally being dropped, consider documenting this breaking change.</comment>
<file context>
@@ -79,52 +79,18 @@
- ]
- }
- ],
+ "target": "nsis",
"icon": "icon.ico",
"verifyUpdateCodeSignature": false
</file context>
| ] | ||
| } | ||
| ], | ||
| "target": "nsis", |
There was a problem hiding this comment.
P2: Removing explicit architecture specification for Windows target will cause builds to only produce artifacts for the build machine's architecture. This removes ARM64 support that was previously configured. Consider keeping the explicit arch specification if multi-architecture builds are needed.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/server-mcp/src/package.json, line 81:
<comment>Removing explicit architecture specification for Windows target will cause builds to only produce artifacts for the build machine's architecture. This removes ARM64 support that was previously configured. Consider keeping the explicit arch specification if multi-architecture builds are needed.</comment>
<file context>
@@ -78,53 +78,19 @@
- ]
- }
- ],
+ "target": "nsis",
"icon": "icon.ico",
"verifyUpdateCodeSignature": false,
</file context>
Greptile Summary
Important Files Changed
Confidence score: 4/5
Sequence DiagramsequenceDiagram
participant Developer
participant GitHub
participant ReleaseAppsStage as "Release Apps Stage Workflow"
participant AgentStage as "Agent Build Stage"
participant DesktopStage as "Desktop App Build Stage"
participant TimerStage as "Desktop Timer App Build Stage"
participant ServerStage as "Server Build Stage"
participant ServerAPIStage as "API Server Build Stage"
participant ServerMCPStage as "MCP Server Build Stage"
participant BumpScript as "Bump Version Script"
participant YarnBuild as "Yarn Build Commands"
participant GitHubReleases as "GitHub Releases"
Developer->>GitHub: "Push to stage-apps/temp branch"
GitHub->>ReleaseAppsStage: "Trigger Release Apps Stage workflow"
ReleaseAppsStage->>GitHub: "Workflow completes successfully"
GitHub->>AgentStage: "Trigger Agent Build Stage workflow"
GitHub->>DesktopStage: "Trigger Desktop App Build Stage workflow"
GitHub->>TimerStage: "Trigger Desktop Timer App Build Stage workflow"
GitHub->>ServerStage: "Trigger Server Build Stage workflow"
GitHub->>ServerAPIStage: "Trigger API Server Build Stage workflow"
GitHub->>ServerMCPStage: "Trigger MCP Server Build Stage workflow"
AgentStage->>BumpScript: "Call bump-version-electron.js for agent"
BumpScript->>AgentStage: "Return updated version"
AgentStage->>YarnBuild: "Execute yarn build:agent:platform:release"
YarnBuild->>GitHubReleases: "Publish agent binaries"
DesktopStage->>BumpScript: "Call bump-version-electron.js for desktop"
BumpScript->>DesktopStage: "Return updated version"
DesktopStage->>YarnBuild: "Execute yarn build:desktop:platform:release"
YarnBuild->>GitHubReleases: "Publish desktop binaries"
TimerStage->>BumpScript: "Call bump-version-electron.js for timer"
BumpScript->>TimerStage: "Return updated version"
TimerStage->>YarnBuild: "Execute yarn build:desktop-timer:platform:release"
YarnBuild->>GitHubReleases: "Publish timer binaries"
ServerStage->>BumpScript: "Call bump-version-electron.js for server"
BumpScript->>ServerStage: "Return updated version"
ServerStage->>YarnBuild: "Execute yarn build:gauzy-server:platform:release"
YarnBuild->>GitHubReleases: "Publish server binaries"
ServerAPIStage->>BumpScript: "Call bump-version-electron.js for api server"
BumpScript->>ServerAPIStage: "Return updated version"
ServerAPIStage->>YarnBuild: "Execute yarn build:gauzy-api-server:platform:release"
YarnBuild->>GitHubReleases: "Publish API server binaries"
ServerMCPStage->>BumpScript: "Call bump-version-electron.js for mcp server"
BumpScript->>ServerMCPStage: "Return updated version"
ServerMCPStage->>YarnBuild: "Execute yarn build:gauzy-mcp-server:platform:release"
YarnBuild->>GitHubReleases: "Publish MCP server binaries"
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Additional Comments (4)
-
apps/server-mcp/src/package.json, line 3-5 (link)logic: Inconsistent naming convention -
productNameanddescriptionstill use 'Ever Gauzy' but PR states apps were renamed to 'Gauzy ...' -
apps/server-api/src/package.json, line 3 (link)style: The
productNameshould be updated to "Gauzy API Server" to match the naming convention mentioned in the PR summary where apps are being renamed from "Ever Gauzy ..." to "Gauzy ..."Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
-
apps/server-api/src/package.json, line 5 (link)style: The
descriptionshould be updated to "Gauzy API Server" to match the naming convention mentioned in the PR summaryNote: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
-
apps/server-api/src/package.json, line 29 (link)style: The
productNamein the build configuration should also be updated to "Gauzy API Server" to maintain consistency with the package naming conventionNote: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
19 files reviewed, 4 comments
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
Summary by cubic
Standardized app naming to “Gauzy …”, simplified Electron build targets, and switched CI to Windows 11 ARM runners for more reliable builds. Removed the obsolete Windows workflow and added repo owner/name variables to support release automation.
Refactors
CI/Build
Written for commit 585a5ba. Summary will update automatically on new commits.