Skip to content

Conversation

@evereq
Copy link
Member

@evereq evereq commented Dec 20, 2025

PR

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.



Summary by cubic

Fixes failing ARM64 builds in CI by adding required Linux X11 dev packages and enabling ARM64 VC tools on Windows across agent, desktop, timer, and server workflows (stage and prod). This should allow Electron and native modules to compile for ARM64.

  • Dependencies
    • Ubuntu: add libx11-dev, libxtst-dev, libxt-dev, libxinerama-dev, libx11-xcb-dev, libxkbcommon-dev, libxkbcommon-x11-dev, libxkbfile-dev.
    • Windows: install Visual Studio 2022 Build Tools with VC Tools ARM64 component via Chocolatey.

Written for commit 20a19dd. Summary will update automatically on new commits.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 20, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@evereq evereq merged commit 16a5afa into stage-apps Dec 20, 2025
25 of 29 checks passed
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 20, 2025

Greptile Summary

This PR adds ARM64 build support across all workflow files by installing necessary build dependencies. Two main changes were applied consistently across 12 workflow files:

Linux ARM64 builds: Added X11 development libraries (libx11-dev, libxtst-dev, libxt-dev, libxinerama-dev, libx11-xcb-dev, libxkbcommon-dev, libxkbcommon-x11-dev, libxkbfile-dev) required for native modules like uiohook-napi used in desktop applications.

Windows ARM64 builds: Added Microsoft.VisualStudio.Component.VC.Tools.ARM64 to Visual Studio 2022 Build Tools installation to enable ARM64 cross-compilation. Also removed --includeOptional flag from the installation command.

The changes are straightforward and address missing build toolchain components for ARM64 architecture support.

Confidence Score: 4/5

  • This PR is safe to merge with minor risk - adds necessary ARM64 build dependencies consistently
  • The changes are minimal, well-targeted, and consistently applied across all workflow files. Adding X11 libraries for Linux ARM64 builds is necessary for native modules like uiohook-napi. Adding ARM64 Visual C++ tools for Windows is required for cross-compilation. The only concern is removal of --includeOptional flag which should be verified doesn't break builds.
  • Verify .github/workflows/agent-prod.yml and other Windows ARM64 builds complete successfully without --includeOptional flag

Important Files Changed

Filename Overview
.github/workflows/agent-prod.yml Added X11 development libraries for Linux ARM64 builds and ARM64 toolchain support for Windows builds
.github/workflows/agent-stage.yml Added X11 development libraries for Linux ARM64 builds and ARM64 toolchain support for Windows builds
.github/workflows/desktop-app-prod.yml Added X11 development libraries for Linux ARM64 builds and ARM64 toolchain support for Windows builds
.github/workflows/desktop-timer-app-prod.yml Added X11 development libraries for Linux ARM64 builds and ARM64 toolchain support for Windows builds

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions
    participant Linux as Linux ARM64 Runner
    participant Win as Windows ARM64 Runner
    participant Build as Build System
    
    Note over GH,Build: ARM64 Build Dependency Installation
    
    GH->>Linux: Trigger Linux ARM64 Build
    Linux->>Linux: Install X11 dev libraries
    Note right of Linux: libx11-dev, libxtst-dev<br/>libxt-dev, libxinerama-dev<br/>libx11-xcb-dev, libxkbcommon*
    Linux->>Build: Compile native modules (uiohook-napi)
    Build->>Linux: ARM64 binaries generated
    
    GH->>Win: Trigger Windows ARM64 Build
    Win->>Win: Install VS 2022 Build Tools
    Note right of Win: Add VCTools workload<br/>Add ARM64 component<br/>(removed --includeOptional)
    Win->>Win: Setup MSVC dev environment (ARM64)
    Win->>Build: Compile native modules
    Build->>Win: ARM64 binaries generated
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

shell: powershell
run: |
choco install -y visualstudio2022buildtools --execution-timeout=21600 --package-parameters "--add Microsoft.VisualStudio.Workload.VCTools --includeRecommended --includeOptional --passive --norestart"
choco install -y visualstudio2022buildtools --execution-timeout=21600 --package-parameters "--add Microsoft.VisualStudio.Workload.VCTools --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 --includeRecommended --passive --norestart"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: --includeOptional was removed from VS build tools - verify ARM64 components include everything needed for native modules like uiohook-napi

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/agent-prod.yml
Line: 365:365

Comment:
**style:** `--includeOptional` was removed from VS build tools - verify ARM64 components include everything needed for native modules like `uiohook-napi`

How can I resolve this? If you propose a fix, please make it concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants