-
Notifications
You must be signed in to change notification settings - Fork 714
chore: quick attempt to fix arm64 builds #9280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 12 files
Greptile SummaryThis PR adds ARM64 build support across all workflow files by installing necessary build dependencies. Two main changes were applied consistently across 12 workflow files: Linux ARM64 builds: Added X11 development libraries ( Windows ARM64 builds: Added The changes are straightforward and address missing build toolchain components for ARM64 architecture support. Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant GH as GitHub Actions
participant Linux as Linux ARM64 Runner
participant Win as Windows ARM64 Runner
participant Build as Build System
Note over GH,Build: ARM64 Build Dependency Installation
GH->>Linux: Trigger Linux ARM64 Build
Linux->>Linux: Install X11 dev libraries
Note right of Linux: libx11-dev, libxtst-dev<br/>libxt-dev, libxinerama-dev<br/>libx11-xcb-dev, libxkbcommon*
Linux->>Build: Compile native modules (uiohook-napi)
Build->>Linux: ARM64 binaries generated
GH->>Win: Trigger Windows ARM64 Build
Win->>Win: Install VS 2022 Build Tools
Note right of Win: Add VCTools workload<br/>Add ARM64 component<br/>(removed --includeOptional)
Win->>Win: Setup MSVC dev environment (ARM64)
Win->>Build: Compile native modules
Build->>Win: ARM64 binaries generated
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
12 files reviewed, 1 comment
| shell: powershell | ||
| run: | | ||
| choco install -y visualstudio2022buildtools --execution-timeout=21600 --package-parameters "--add Microsoft.VisualStudio.Workload.VCTools --includeRecommended --includeOptional --passive --norestart" | ||
| choco install -y visualstudio2022buildtools --execution-timeout=21600 --package-parameters "--add Microsoft.VisualStudio.Workload.VCTools --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 --includeRecommended --passive --norestart" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: --includeOptional was removed from VS build tools - verify ARM64 components include everything needed for native modules like uiohook-napi
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/agent-prod.yml
Line: 365:365
Comment:
**style:** `--includeOptional` was removed from VS build tools - verify ARM64 components include everything needed for native modules like `uiohook-napi`
How can I resolve this? If you propose a fix, please make it concise.
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
Summary by cubic
Fixes failing ARM64 builds in CI by adding required Linux X11 dev packages and enabling ARM64 VC tools on Windows across agent, desktop, timer, and server workflows (stage and prod). This should allow Electron and native modules to compile for ARM64.
Written for commit 20a19dd. Summary will update automatically on new commits.