Stage #9281
Merged
Stage #9281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the downloads section to clarify that all releases and pre-releases are available from specified pages.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 23 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="README.md">
<violation number="1" location="README.md:133">
P3: Grammar issue: "pre-releases downloads" should be "pre-release downloads" (adjective form should be singular).</violation>
</file>
<file name=".github/workflows/agent-prod.yml">
<violation number="1" location=".github/workflows/agent-prod.yml:137">
P1: Incorrect environment variable names. The `bump-version-electron.js` script expects `AGENT_APP_*` variables but this job uses `DESKTOP_AGENT_APP_*` which the script doesn't read. This will cause the version bump to fail or use undefined values.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| - [Server Releases](https://github.com/ever-co/ever-gauzy-server/releases) | ||
| - [Desktop App Releases](https://github.com/ever-co/ever-gauzy-desktop/releases) | ||
| - [Desktop Timer App Releases](https://github.com/ever-co/ever-gauzy-desktop-timer/releases) | ||
| In addition, all releases and pre-releases downloads are also available from the following pages: |
Contributor
There was a problem hiding this comment.
P3: Grammar issue: "pre-releases downloads" should be "pre-release downloads" (adjective form should be singular).
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At README.md, line 133:
<comment>Grammar issue: "pre-releases downloads" should be "pre-release downloads" (adjective form should be singular).</comment>
<file context>
@@ -130,12 +130,9 @@ Notes:
-- [Server Releases](https://github.com/ever-co/ever-gauzy-server/releases)
-- [Desktop App Releases](https://github.com/ever-co/ever-gauzy-desktop/releases)
-- [Desktop Timer App Releases](https://github.com/ever-co/ever-gauzy-desktop-timer/releases)
+In addition, all releases and pre-releases downloads are also available from the following pages:
+- [Platform Releases](https://github.com/ever-co/ever-gauzy/releases)
+- [Apps](https://github.com/ever-co/ever-gauzy/wiki/Gauzy-Desktop-Apps)
</file context>
Suggested change
| In addition, all releases and pre-releases downloads are also available from the following pages: | |
| In addition, all releases and pre-release downloads are also available from the following pages: |
Comment on lines
+137
to
+142
| DESKTOP_AGENT_APP_NAME: 'gauzy-agent' | ||
| DESKTOP_AGENT_APP_REPO_NAME: 'ever-gauzy-agent' | ||
| DESKTOP_AGENT_APP_REPO_OWNER: 'ever-co' | ||
| COMPANY_SITE_LINK: 'https://gauzy.co' | ||
| DESKTOP_AGENT_APP_DESCRIPTION: 'Gauzy Agent' | ||
| DESKTOP_AGENT_APP_ID: 'com.ever.gauzyagent' |
Contributor
There was a problem hiding this comment.
P1: Incorrect environment variable names. The bump-version-electron.js script expects AGENT_APP_* variables but this job uses DESKTOP_AGENT_APP_* which the script doesn't read. This will cause the version bump to fail or use undefined values.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/agent-prod.yml, line 137:
<comment>Incorrect environment variable names. The `bump-version-electron.js` script expects `AGENT_APP_*` variables but this job uses `DESKTOP_AGENT_APP_*` which the script doesn't read. This will cause the version bump to fail or use undefined values.</comment>
<file context>
@@ -57,34 +60,110 @@ jobs:
+ console.log(script.agent(true))
+ env:
+ PROJECT_REPO: 'https://github.com/ever-co/ever-gauzy.git'
+ DESKTOP_AGENT_APP_NAME: 'gauzy-agent'
+ DESKTOP_AGENT_APP_REPO_NAME: 'ever-gauzy-agent'
+ DESKTOP_AGENT_APP_REPO_OWNER: 'ever-co'
</file context>
Suggested change
| DESKTOP_AGENT_APP_NAME: 'gauzy-agent' | |
| DESKTOP_AGENT_APP_REPO_NAME: 'ever-gauzy-agent' | |
| DESKTOP_AGENT_APP_REPO_OWNER: 'ever-co' | |
| COMPANY_SITE_LINK: 'https://gauzy.co' | |
| DESKTOP_AGENT_APP_DESCRIPTION: 'Gauzy Agent' | |
| DESKTOP_AGENT_APP_ID: 'com.ever.gauzyagent' | |
| AGENT_APP_NAME: 'gauzy-agent' | |
| AGENT_APP_REPO_NAME: 'ever-gauzy-agent' | |
| AGENT_APP_REPO_OWNER: 'ever-co' | |
| COMPANY_SITE_LINK: 'https://gauzy.co' | |
| AGENT_APP_DESCRIPTION: 'Gauzy Agent' | |
| AGENT_APP_ID: 'com.ever.gauzyagent' |
Contributor
Greptile Summaryadded multi-architecture (x64 and ARM64) build support for all Electron-based apps across Linux, Windows, and macOS platforms Key Changes:
Critical Issues Found:
PR Compliance Issue:
Confidence Score: 1/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant Build as Build System
participant Electron as Electron Builder
participant Dist as Distribution (GitHub/Spaces)
Dev->>GH: Push to master/stage branch
GH->>GH: Trigger workflow on Release completion
par Linux x64 Build
GH->>Build: Spin up buildjet-16vcpu-ubuntu runner
Build->>Build: Install dependencies & system packages
Build->>Build: Install Snapcraft
Build->>Build: Run bump-version-electron.js<br/>(Read AGENT_APP_* env vars)
Build->>Electron: Execute build:agent:linux:release:gh:x64
Electron->>Electron: Build for x64 architecture
Electron->>Dist: Publish artifacts (deb, snap, tar.gz, rpm, AppImage)
and Linux ARM64 Build
GH->>Build: Spin up ubicloud-standard-16-arm runner
Build->>Build: Install dependencies & ARM64 libraries
Build->>Build: Install Snapcraft
Build->>Build: Run bump-version-electron.js<br/>(ERROR: expects AGENT_APP_* but receives DESKTOP_AGENT_APP_*)
Build->>Electron: Execute build:agent:linux:release:gh:arm64
Electron->>Electron: Build for ARM64 architecture
Electron->>Dist: Publish artifacts (deb, snap, tar.gz, rpm, AppImage)
and macOS Universal Build
GH->>Build: Spin up warp-macos-15-arm64-12x runner
Build->>Build: Install dependencies
Build->>Build: Run bump-version-electron.js<br/>(Read AGENT_APP_* env vars)
Build->>Electron: Execute build:agent:mac:release
Electron->>Electron: Build for x64 + ARM64 (universal)
Electron->>Dist: Publish artifacts (zip, dmg)
and Windows ARM64 Build
GH->>Build: Spin up warp-windows-latest-arm64 runner
Build->>Build: Install VS 2022 Build Tools
Build->>Build: Configure MSVC for ARM64
Build->>Build: Run bump-version-electron.js<br/>(ERROR: expects AGENT_APP_* but receives DESKTOP_AGENT_APP_*)
Build->>Electron: Execute build:agent:windows:release:gh:arm64
Electron->>Electron: Build for ARM64 architecture
Electron->>Dist: Publish artifacts (nsis installer)
end
Dist-->>Dev: Release artifacts available
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+137
to
+142
| DESKTOP_AGENT_APP_NAME: 'gauzy-agent' | ||
| DESKTOP_AGENT_APP_REPO_NAME: 'ever-gauzy-agent' | ||
| DESKTOP_AGENT_APP_REPO_OWNER: 'ever-co' | ||
| COMPANY_SITE_LINK: 'https://gauzy.co' | ||
| DESKTOP_AGENT_APP_DESCRIPTION: 'Gauzy Agent' | ||
| DESKTOP_AGENT_APP_ID: 'com.ever.gauzyagent' |
Contributor
There was a problem hiding this comment.
logic: incorrect environment variable prefix - script expects AGENT_APP_* but DESKTOP_AGENT_APP_* is used
Suggested change
| DESKTOP_AGENT_APP_NAME: 'gauzy-agent' | |
| DESKTOP_AGENT_APP_REPO_NAME: 'ever-gauzy-agent' | |
| DESKTOP_AGENT_APP_REPO_OWNER: 'ever-co' | |
| COMPANY_SITE_LINK: 'https://gauzy.co' | |
| DESKTOP_AGENT_APP_DESCRIPTION: 'Gauzy Agent' | |
| DESKTOP_AGENT_APP_ID: 'com.ever.gauzyagent' | |
| env: | |
| PROJECT_REPO: 'https://github.com/ever-co/ever-gauzy.git' | |
| AGENT_APP_NAME: 'gauzy-agent' | |
| AGENT_APP_REPO_NAME: 'ever-gauzy-agent' | |
| AGENT_APP_REPO_OWNER: 'ever-co' | |
| COMPANY_SITE_LINK: 'https://gauzy.co' | |
| AGENT_APP_DESCRIPTION: 'Gauzy Agent' | |
| AGENT_APP_ID: 'com.ever.gauzyagent' |
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/agent-prod.yml
Line: 137:142
Comment:
**logic:** incorrect environment variable prefix - script expects `AGENT_APP_*` but `DESKTOP_AGENT_APP_*` is used
```suggestion
env:
PROJECT_REPO: 'https://github.com/ever-co/ever-gauzy.git'
AGENT_APP_NAME: 'gauzy-agent'
AGENT_APP_REPO_NAME: 'ever-gauzy-agent'
AGENT_APP_REPO_OWNER: 'ever-co'
COMPANY_SITE_LINK: 'https://gauzy.co'
AGENT_APP_DESCRIPTION: 'Gauzy Agent'
AGENT_APP_ID: 'com.ever.gauzyagent'
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+137
to
+142
| DESKTOP_AGENT_APP_NAME: 'gauzy-agent' | ||
| DESKTOP_AGENT_APP_REPO_NAME: 'ever-gauzy-agent' | ||
| DESKTOP_AGENT_APP_REPO_OWNER: 'ever-co' | ||
| COMPANY_SITE_LINK: 'https://gauzy.co' | ||
| DESKTOP_AGENT_APP_DESCRIPTION: 'Gauzy Agent' | ||
| DESKTOP_AGENT_APP_ID: 'com.ever.gauzyagent' |
Contributor
There was a problem hiding this comment.
logic: incorrect environment variable prefix - script expects AGENT_APP_* but DESKTOP_AGENT_APP_* is used
Suggested change
| DESKTOP_AGENT_APP_NAME: 'gauzy-agent' | |
| DESKTOP_AGENT_APP_REPO_NAME: 'ever-gauzy-agent' | |
| DESKTOP_AGENT_APP_REPO_OWNER: 'ever-co' | |
| COMPANY_SITE_LINK: 'https://gauzy.co' | |
| DESKTOP_AGENT_APP_DESCRIPTION: 'Gauzy Agent' | |
| DESKTOP_AGENT_APP_ID: 'com.ever.gauzyagent' | |
| env: | |
| PROJECT_REPO: 'https://github.com/ever-co/ever-gauzy.git' | |
| AGENT_APP_NAME: 'gauzy-agent' | |
| AGENT_APP_REPO_NAME: 'ever-gauzy-agent' | |
| AGENT_APP_REPO_OWNER: 'ever-co' | |
| COMPANY_SITE_LINK: 'https://gauzy.co' | |
| AGENT_APP_DESCRIPTION: 'Gauzy Agent' | |
| AGENT_APP_ID: 'com.ever.gauzyagent' |
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/agent-stage.yml
Line: 137:142
Comment:
**logic:** incorrect environment variable prefix - script expects `AGENT_APP_*` but `DESKTOP_AGENT_APP_*` is used
```suggestion
env:
PROJECT_REPO: 'https://github.com/ever-co/ever-gauzy.git'
AGENT_APP_NAME: 'gauzy-agent'
AGENT_APP_REPO_NAME: 'ever-gauzy-agent'
AGENT_APP_REPO_OWNER: 'ever-co'
COMPANY_SITE_LINK: 'https://gauzy.co'
AGENT_APP_DESCRIPTION: 'Gauzy Agent'
AGENT_APP_ID: 'com.ever.gauzyagent'
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+417
to
+422
| DESKTOP_AGENT_APP_NAME: 'gauzy-agent' | ||
| DESKTOP_AGENT_APP_REPO_NAME: 'ever-gauzy-agent' | ||
| DESKTOP_AGENT_APP_REPO_OWNER: 'ever-co' | ||
| COMPANY_SITE_LINK: 'https://gauzy.co' | ||
| DESKTOP_AGENT_APP_DESCRIPTION: 'Gauzy Agent' | ||
| DESKTOP_AGENT_APP_ID: 'com.ever.gauzyagent' |
Contributor
There was a problem hiding this comment.
logic: incorrect environment variable prefix - script expects AGENT_APP_* but DESKTOP_AGENT_APP_* is used
Suggested change
| DESKTOP_AGENT_APP_NAME: 'gauzy-agent' | |
| DESKTOP_AGENT_APP_REPO_NAME: 'ever-gauzy-agent' | |
| DESKTOP_AGENT_APP_REPO_OWNER: 'ever-co' | |
| COMPANY_SITE_LINK: 'https://gauzy.co' | |
| DESKTOP_AGENT_APP_DESCRIPTION: 'Gauzy Agent' | |
| DESKTOP_AGENT_APP_ID: 'com.ever.gauzyagent' | |
| env: | |
| PROJECT_REPO: 'https://github.com/ever-co/ever-gauzy.git' | |
| AGENT_APP_NAME: 'gauzy-agent' | |
| AGENT_APP_REPO_NAME: 'ever-gauzy-agent' | |
| AGENT_APP_REPO_OWNER: 'ever-co' | |
| COMPANY_SITE_LINK: 'https://gauzy.co' | |
| AGENT_APP_DESCRIPTION: 'Gauzy Agent' | |
| AGENT_APP_ID: 'com.ever.gauzyagent' |
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/agent-stage.yml
Line: 417:422
Comment:
**logic:** incorrect environment variable prefix - script expects `AGENT_APP_*` but `DESKTOP_AGENT_APP_*` is used
```suggestion
env:
PROJECT_REPO: 'https://github.com/ever-co/ever-gauzy.git'
AGENT_APP_NAME: 'gauzy-agent'
AGENT_APP_REPO_NAME: 'ever-gauzy-agent'
AGENT_APP_REPO_OWNER: 'ever-co'
COMPANY_SITE_LINK: 'https://gauzy.co'
AGENT_APP_DESCRIPTION: 'Gauzy Agent'
AGENT_APP_ID: 'com.ever.gauzyagent'
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+417
to
+422
| DESKTOP_AGENT_APP_NAME: 'gauzy-agent' | ||
| DESKTOP_AGENT_APP_REPO_NAME: 'ever-gauzy-agent' | ||
| DESKTOP_AGENT_APP_REPO_OWNER: 'ever-co' | ||
| COMPANY_SITE_LINK: 'https://gauzy.co' | ||
| DESKTOP_AGENT_APP_DESCRIPTION: 'Gauzy Agent' | ||
| DESKTOP_AGENT_APP_ID: 'com.ever.gauzyagent' |
Contributor
There was a problem hiding this comment.
logic: incorrect environment variable prefix - script expects AGENT_APP_* but DESKTOP_AGENT_APP_* is used
Suggested change
| DESKTOP_AGENT_APP_NAME: 'gauzy-agent' | |
| DESKTOP_AGENT_APP_REPO_NAME: 'ever-gauzy-agent' | |
| DESKTOP_AGENT_APP_REPO_OWNER: 'ever-co' | |
| COMPANY_SITE_LINK: 'https://gauzy.co' | |
| DESKTOP_AGENT_APP_DESCRIPTION: 'Gauzy Agent' | |
| DESKTOP_AGENT_APP_ID: 'com.ever.gauzyagent' | |
| AGENT_APP_NAME: 'gauzy-agent' | |
| AGENT_APP_REPO_NAME: 'ever-gauzy-agent' | |
| AGENT_APP_REPO_OWNER: 'ever-co' | |
| COMPANY_SITE_LINK: 'https://gauzy.co' | |
| AGENT_APP_DESCRIPTION: 'Gauzy Agent' | |
| AGENT_APP_ID: 'com.ever.gauzyagent' |
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/agent-prod.yml
Line: 417:422
Comment:
**logic:** incorrect environment variable prefix - script expects `AGENT_APP_*` but `DESKTOP_AGENT_APP_*` is used
```suggestion
AGENT_APP_NAME: 'gauzy-agent'
AGENT_APP_REPO_NAME: 'ever-gauzy-agent'
AGENT_APP_REPO_OWNER: 'ever-co'
COMPANY_SITE_LINK: 'https://gauzy.co'
AGENT_APP_DESCRIPTION: 'Gauzy Agent'
AGENT_APP_ID: 'com.ever.gauzyagent'
```
How can I resolve this? If you propose a fix, please make it concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
Summary by cubic
Adds multi-architecture builds (x64 and arm64) across apps and servers, integrates Snapcraft into CI, and standardizes artifact names. This expands release coverage and stabilizes arm64 builds.
New Features
Bug Fixes
Written for commit d5a4f7e. Summary will update automatically on new commits.