Skip to content

Conversation

@evereq
Copy link
Member

@evereq evereq commented Dec 20, 2025

PR

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.



Summary by cubic

Set SNAPCRAFT_BUILD_ENVIRONMENT=host across all Linux GitHub Actions workflows to run Snapcraft builds directly on the runner. This standardizes and stabilizes Linux builds for agent, desktop, and server pipelines.

  • Bug Fixes
    • Removes LXD/Multipass dependency on runners, preventing snap build failures/timeouts.
    • Applied to stage and prod for: agent, desktop-app, desktop-timer-app, server, server-api, server-mcp.

Written for commit f02efe5. Summary will update automatically on new commits.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 20, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@evereq evereq merged commit d174743 into stage-apps Dec 20, 2025
19 of 22 checks passed
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 20, 2025

Greptile Summary

This PR adds SNAPCRAFT_BUILD_ENVIRONMENT: host to arm64 Linux build jobs across 12 workflow files. This environment variable configures Snapcraft to build directly on the host system instead of creating a Multipass VM, which should improve build performance on arm64 runners.

Key Changes:

  • Added SNAPCRAFT_BUILD_ENVIRONMENT: host to release-linux-arm64 jobs in all 12 workflow files
  • Complements the previous commit that installed Multipass on arm64 runners
  • x64 Linux jobs (release-linux) remain unchanged - they don't have Multipass or this environment variable

Note on PR Title:
The PR title states "all Linux workflows" but the change only affects arm64 Linux jobs, not x64 Linux jobs. The release-linux jobs (x64) don't have Multipass installed and don't have this environment variable set. This appears intentional based on the commit history, but the title could be more specific (e.g., "set SNAPCRAFT_BUILD_ENVIRONMENT to host in all Linux arm64 workflows").

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a simple, consistent addition of a single environment variable across 12 workflow files. The SNAPCRAFT_BUILD_ENVIRONMENT: host setting is a standard Snapcraft configuration that tells the tool to build on the host rather than in a VM. The changes are identical across all files, properly scoped to arm64 jobs only (matching the Multipass installation pattern), and won't break existing builds since this is an additive change that optimizes build performance.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/agent-prod.yml Added SNAPCRAFT_BUILD_ENVIRONMENT: host to arm64 Linux job
.github/workflows/desktop-app-prod.yml Added SNAPCRAFT_BUILD_ENVIRONMENT: host to arm64 Linux job
.github/workflows/server-prod.yml Added SNAPCRAFT_BUILD_ENVIRONMENT: host to arm64 Linux job

Sequence Diagram

sequenceDiagram
    participant GHA as GitHub Actions
    participant Runner as UbiCloud ARM64 Runner
    participant Snapcraft as Snapcraft Tool
    participant Multipass as Multipass VM
    participant Host as Host System
    
    Note over GHA,Host: ARM64 Linux Build Process
    
    GHA->>Runner: Trigger workflow on push
    Runner->>Runner: Install dependencies
    Runner->>Snapcraft: Install Snapcraft via action
    Runner->>Multipass: Install Multipass via snap
    Runner->>Runner: Set SNAPCRAFT_BUILD_ENVIRONMENT=host
    
    Note over Snapcraft,Host: Build Environment Decision
    
    alt SNAPCRAFT_BUILD_ENVIRONMENT=host (NEW)
        Snapcraft->>Host: Build directly on host system
        Host->>Host: Execute snap build
        Host-->>Snapcraft: Build artifacts
    else Without SNAPCRAFT_BUILD_ENVIRONMENT (OLD)
        Snapcraft->>Multipass: Launch VM for isolated build
        Multipass->>Multipass: Create virtual machine
        Multipass->>Multipass: Execute snap build in VM
        Multipass-->>Snapcraft: Build artifacts
    end
    
    Snapcraft-->>Runner: Return build output
    Runner-->>GHA: Upload artifacts/publish
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants