Skip to content

Conversation

@evereq
Copy link
Member

@evereq evereq commented Dec 21, 2025

PR

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.



Summary by cubic

Halved build memory requirements to run reliably on ~32GB machines and reduce CI costs. Node heap limits are lowered and GitHub runners use smaller flavors.

  • Refactors
    • Set NODE_OPTIONS max-old-space-size to 30000 in Dockerfiles and all docker/release scripts.
    • Switched GitHub Actions runners: ubicloud-standard-16 → 8, macOS 12x → 6x, Windows 16x → 8x.
    • No functional changes to application code.

Written for commit bc225ff. Summary will update automatically on new commits.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 21, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@evereq evereq merged commit 220da8b into chore/upgrade-node-version Dec 21, 2025
19 of 22 checks passed
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 26 files

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 21, 2025

Greptile Summary

This PR reduces RAM memory allocations across Docker builds, GitHub workflows, and build scripts by scaling down from 60GB to 30GB for the NODE_OPTIONS --max-old-space-size parameter. The changes are applied consistently across 26 files including 4 Dockerfiles, 18 GitHub workflow files, and package.json with 92 script updates. Additionally, CI runner machine sizes are reduced (e.g., ubicloud-standard-16 → ubicloud-standard-8, warp-macos-15-arm64-12x → warp-macos-15-arm64-6x) to align with the lower RAM requirements. All changes are systematic, consistent, and contain no logic errors.

Note: The PR template checkboxes were not completed as required by the contributing guidelines.

Confidence Score: 5/5

  • This PR is safe to merge. All changes are straightforward configuration reductions with no functional impact.
  • The PR consists entirely of systematic configuration changes reducing memory allocations and runner resources. All 92 package.json changes are consistent, all Dockerfile changes apply the same NODE_OPTIONS reduction, and all GitHub workflow changes scale down CI runner sizes proportionally. No code logic is modified, no dependencies are changed, and there are no syntax or functional issues. The only concern is the incomplete PR template checklist, which is a process issue rather than a technical one.
  • No files require special technical attention. However, future PRs should ensure PR template requirements are met.

Important Files Changed

Filename Overview
package.json Consistently updated 92 instances of NODE_OPTIONS --max-old-space-size from 60000 to 30000 for Docker builds and GitHub release scripts
.deploy/api/Dockerfile Updated NODE_OPTIONS default max-old-space-size from 60000 to 30000 in the build stage
.deploy/mcp-auth/Dockerfile Updated NODE_OPTIONS default max-old-space-size from 60000 to 30000 in the build stage
.deploy/mcp/Dockerfile Updated NODE_OPTIONS default max-old-space-size from 60000 to 30000 in the build stage
.deploy/webapp/Dockerfile Updated NODE_OPTIONS default max-old-space-size from 60000 to 30000 in the build stage
.github/workflows/agent-prod.yml Scaled down runner resources: ubicloud-standard-16 → ubicloud-standard-8, ubicloud-standard-16-arm → ubicloud-standard-8-arm, warp-macos-15-arm64-12x → warp-macos-15-arm64-6x, warp-windows-latest-x64-16x → warp-windows-latest-x64-8x
.github/workflows/server-prod.yml Scaled down runner resources: ubicloud-standard-16 → ubicloud-standard-8, ubicloud-standard-16-arm → ubicloud-standard-8-arm, warp-macos-15-arm64-12x → warp-macos-15-arm64-6x, warp-windows-latest-x64-16x → warp-windows-latest-x64-8x

Sequence Diagram

sequenceDiagram
    participant CI as CI/CD Pipeline
    participant Docker as Docker Build
    participant Workflow as GitHub Workflow
    
    Note over CI,Workflow: Before PR: 60GB RAM allocation
    CI->>Docker: Build with NODE_OPTIONS=60000MB
    Docker->>Docker: Compile & Build
    CI->>Workflow: Run on 16-core/12x machines
    Workflow->>Workflow: Execute build tasks
    
    Note over CI,Workflow: After PR: 30GB RAM allocation
    CI->>Docker: Build with NODE_OPTIONS=30000MB
    Docker->>Docker: Compile & Build (reduced memory)
    CI->>Workflow: Run on 8-core/6x machines
    Workflow->>Workflow: Execute build tasks (reduced resources)
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. package.json, line 1 (link)

    style: PR template checkboxes were not completed. Please review the contributing guidelines and ensure all template requirements are met before submitting future PRs.

    Context Used: Context from dashboard - Always check the boxes in the PR template and provide all requested information, or the PR may be cl... (source)

26 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants