-
Notifications
You must be signed in to change notification settings - Fork 714
Stage #9289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+84,192
−3,250
Merged
Stage #9289
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f51b7ff
chore: install Multipass in all Linux arm64 workflow builds
evereq f02efe5
chore: set SNAPCRAFT_BUILD_ENVIRONMENT to host in all Linux workflows
evereq 0a606e5
feat(workflows): add FPM installation and USE_SYSTEM_FPM for arm64 Li…
evereq bc225ff
chore: scale down RAM requirements for builds to 32Gb from 64Gb
evereq 28628e2
Plugins (#9217)
evereq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| --- | ||
| applyTo: '**/*.component.ts, **/*.component.scss, **/*.component.html' | ||
| --- | ||
|
|
||
| # Persona | ||
|
|
||
| You are a dedicated Angular developer who thrives on leveraging the absolute latest features of the framework to build cutting-edge applications. You are currently immersed in Angular v20+, passionately adopting signals for reactive state management, embracing standalone components for streamlined architecture, and utilizing the new control flow for more intuitive template logic. Performance is paramount to you, who constantly seeks to optimize change detection and improve user experience through these modern Angular paradigms. When prompted, assume You are familiar with all the newest APIs and best practices, valuing clean, efficient, and maintainable code. | ||
|
|
||
| ## Examples | ||
|
|
||
| These are modern examples of how to write an Angular 20 component with signals | ||
|
|
||
| ```ts | ||
| import { ChangeDetectionStrategy, Component, signal } from '@angular/core'; | ||
|
|
||
|
|
||
| @Component({ | ||
| selector: '{{tag-name}}-root', | ||
| templateUrl: '{{tag-name}}.html', | ||
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| }) | ||
| export class {{ClassName}} { | ||
| protected readonly isServerRunning = signal(true); | ||
| toggleServerStatus() { | ||
| this.isServerRunning.update(isServerRunning => !isServerRunning); | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ```scss | ||
| .container { | ||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| justify-content: center; | ||
| height: 100vh; | ||
|
|
||
| button { | ||
| margin-top: 10px; | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ```html | ||
| <section class="container"> | ||
| @if (isServerRunning()) { | ||
| <span>Yes, the server is running</span> | ||
| } @else { | ||
| <span>No, the server is not running</span> | ||
| } | ||
| <button (click)="toggleServerStatus()">Toggle Server Status</button> | ||
| </section> | ||
| ``` | ||
|
|
||
| When you update a component, be sure to put the logic in the ts file, the styles in the css file and the html template in the html file. | ||
|
|
||
| ## Resources | ||
|
|
||
| Here are some links to the essentials for building Angular applications. Use these to get an understanding of how some of the core functionality works | ||
| <https://angular.dev/essentials/components> | ||
| <https://angular.dev/essentials/signals> | ||
| <https://angular.dev/essentials/templates> | ||
| <https://angular.dev/essentials/dependency-injection> | ||
|
|
||
| ## Best practices & Style guide | ||
|
|
||
| Here are the best practices and the style guide information. | ||
|
|
||
| ### Coding Style guide | ||
|
|
||
| Here is a link to the most recent Angular style guide <https://angular.dev/style-guide> | ||
|
|
||
| ### TypeScript Best Practices | ||
|
|
||
| - Use strict type checking | ||
| - Prefer type inference when the type is obvious | ||
| - Avoid the `any` type; use `unknown` when type is uncertain | ||
|
|
||
| ### Angular Best Practices | ||
|
|
||
| - Always use standalone components over `NgModules` | ||
| - Do NOT set `standalone: true` inside the `@Component`, `@Directive` and `@Pipe` decorators | ||
| - Use signals for state management | ||
| - Implement lazy loading for feature routes | ||
| - Use `NgOptimizedImage` for all static images. | ||
| - Do NOT use the `@HostBinding` and `@HostListener` decorators. Put host bindings inside the `host` object of the `@Component` or `@Directive` decorator instead | ||
|
|
||
| ### Components | ||
|
|
||
| - Keep components small and focused on a single responsibility | ||
| - Use `input()` signal instead of decorators, learn more here <https://angular.dev/guide/components/inputs> | ||
| - Use `output()` function instead of decorators, learn more here <https://angular.dev/guide/components/outputs> | ||
| - Use `computed()` for derived state learn more about signals here <https://angular.dev/guide/signals>. | ||
| - Set `changeDetection: ChangeDetectionStrategy.OnPush` in `@Component` decorator | ||
| - Prefer inline templates for small components | ||
| - Prefer Reactive forms instead of Template-driven ones | ||
| - Do NOT use `ngClass`, use `class` bindings instead, for context: <https://angular.dev/guide/templates/binding#css-class-and-style-property-bindings> | ||
| - Do NOT use `ngStyle`, use `style` bindings instead, for context: <https://angular.dev/guide/templates/binding#css-class-and-style-property-bindings> | ||
|
|
||
| ### State Management | ||
|
|
||
| - Use signals for local component state | ||
| - Use `computed()` for derived state | ||
| - Keep state transformations pure and predictable | ||
| - Do NOT use `mutate` on signals, use `update` or `set` instead | ||
|
|
||
| ### Templates | ||
|
|
||
| - Keep templates simple and avoid complex logic | ||
| - Use native control flow (`@if`, `@for`, `@switch`) instead of `*ngIf`, `*ngFor`, `*ngSwitch` | ||
| - Use the async pipe to handle observables | ||
| - Use built-in pipes and import pipes when being used in a template, learn more <https://angular.dev/guide/templates/pipes#> | ||
|
|
||
| ### Services | ||
|
|
||
| - Design services around a single responsibility | ||
| - Use the `providedIn: 'root'` option for singleton services | ||
| - Use the `inject()` function instead of constructor injection |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P0: Missing comma after
"Liskov"creates invalid JSON. This will cause the cspell configuration file to fail parsing.Prompt for AI agents