-
Notifications
You must be signed in to change notification settings - Fork 714
chore: upgrade node version from v20.18.1 to v24.12.0 (#9286) #9292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Ruslan Konviser <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 16 files
Greptile SummaryThis PR upgrades Node.js across Dockerfiles and GitHub Actions workflows, but has inconsistencies that need to be addressed. Key Changes:
Critical Issue:
Additional Notes:
Confidence Score: 2/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant Docker as Docker Build
participant Runtime as Application Runtime
Dev->>GH: Push code to stage-apps
GH->>GH: Setup Node.js v24.12.0
GH->>GH: Install NPM v11.6.2
GH->>GH: Install dependencies with yarn
GH->>GH: Build application
GH->>Docker: Trigger Docker build
Docker->>Docker: Use node:24.12.0-alpine3.23
Docker->>Docker: Build multi-stage image
Docker->>Runtime: Deploy container
Runtime->>Runtime: Run with Node.js v24.12.0
Note over GH,Runtime: Package.json still specifies >=20.18.1
Note over Runtime: Version mismatch between runtime and package specs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
package.json, line 694 (link)logic: Engine requirement must be updated to match the new Node.js version. All package.json files still specify
>=20.18.1but runtime now uses v24.12.0.
16 files reviewed, 1 comment
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
Summary by cubic
Upgraded Node.js to v24.12.0 across Docker images and CI workflows for a consistent, modern runtime. Also bumped npm to v11.6.2.
Dependencies
Migration
Written for commit f64ef57. Summary will update automatically on new commits.