Skip to content

Conversation

@evereq
Copy link
Member

@evereq evereq commented Dec 23, 2025

PR

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.



Summary by cubic

Upgrade the toolchain to Node.js 24 and align Angular to 19.2.17 across the monorepo. This standardizes builds, updates Docker/CI to the latest stack, and removes legacy migration config.

  • Dependencies

    • Bumped Angular packages to 19.2.17 and @Angular-devkit to ^0.1902.17.
    • Switched Docker images to node:24.12.0-alpine3.23 for api, mcp, mcp-auth, and webapp.
    • Updated CI workflows to Node 24.12.0 and npm 11.6.2.
    • Set package engines to Node >=22; updated .nvmrc to 24.
    • Removed migrations.json and added it to .gitignore; refreshed yarn.lock; minor README formatting.
  • Migration

    • Use Node 22+ locally (recommended 24.12.0) and npm 11.6+; run yarn install and rebuild apps.
    • Rebuild Docker images to pick up the Node 24/alpine3.23 base.

Written for commit 1a8db2c. Summary will update automatically on new commits.

syns2191 and others added 4 commits December 22, 2025 23:12
…#9291)

* chore: upgrade angular dependencies version from v19.2.10 to v19.2.17

* chore: upgrade @angular/material and other deps related to angular version

* Delete migrations.json

* Update .gitignore

---------

Co-authored-by: Ruslan Konviser <[email protected]>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 23, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch stage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@evereq evereq merged commit c4ed307 into stage-apps Dec 23, 2025
17 of 21 checks passed
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 83 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 23, 2025

Greptile Summary

This PR merges changes from the develop branch into stage-apps, including Node.js version upgrade and Angular dependency updates.

  • Updated Node.js version from 21 to 24 in .nvmrc
  • Upgraded Angular dependencies from v19.2.10/11 to v19.2.17 across all packages
  • Updated package.json engines to require Node >=22 (minor inconsistency with .nvmrc which specifies 24)
  • Updated README to recommend Node 22.x or 24.x and clarify Yarn version requirements
  • Removed migrations.json and added it to .gitignore (NX migration artifact cleanup)
  • Updated yarn.lock with new dependency versions

The PR description checkboxes are not completed, which violates the contributing guidelines per custom rule 90653f25-bd57-4517-ae57-772fe2013d9c.

Confidence Score: 4/5

  • This PR is safe to merge with only minor style concerns
  • This is a straightforward dependency update PR that upgrades Node.js and Angular versions. The changes are mechanical and consistent across all packages. Only minor issue is a slight version inconsistency between .nvmrc (Node 24) and package.json engines (Node >=22), which doesn't affect functionality. The PR also violates the contributing guidelines by not completing the PR template checklist boxes, though this is a process issue rather than a code quality concern.
  • package.json has minor version inconsistency with .nvmrc, but no critical issues requiring attention

Important Files Changed

Filename Overview
.nvmrc Updated Node.js version from 21 to 24
package.json Updated Angular deps to 19.2.17 and engine requirements to Node >=22, but .nvmrc specifies Node 24 - minor version mismatch
README.md Updated documentation to recommend Node 22.x or 24.x and clarified Yarn version requirements
migrations.json Removed migrations.json file (was a temporary NX migration artifact)
.gitignore Added migrations.json to gitignore to prevent future tracking of NX migration artifacts
yarn.lock Updated lock file with Angular 19.2.17 and related dependencies
apps/gauzy/package.json Updated Angular dependencies from 19.2.10/11 to 19.2.17

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Develop as develop branch
    participant PR as PR #9294
    participant Stage as stage-apps branch
    
    Note over Dev,Develop: Node & Angular Updates
    Dev->>Develop: Update .nvmrc (21 → 24)
    Dev->>Develop: Upgrade Angular deps (19.2.10 → 19.2.17)
    Dev->>Develop: Update package.json engines
    Dev->>Develop: Update README documentation
    Dev->>Develop: Remove migrations.json
    Dev->>Develop: Update .gitignore
    
    Note over Develop,PR: Dependency Resolution
    Develop->>PR: yarn.lock updated with new deps
    PR->>PR: 83 files changed (package.json files)
    
    Note over PR,Stage: Merge to Stage
    PR->>Stage: Merge changes to stage-apps
    Stage->>Stage: CI/CD builds with Node 24
    Stage->>Stage: Angular 19.2.17 runtime
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

82 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

"engines": {
"node": ">=20.18.1",
"yarn": ">=1.22.19"
"node": ">=22",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: .nvmrc specifies Node 24, but engines requires >=22 - consider aligning to >=24 for consistency

Suggested change
"node": ">=22",
"node": ">=24",

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 694:694

Comment:
**style:** `.nvmrc` specifies Node 24, but engines requires `>=22` - consider aligning to `>=24` for consistency

```suggestion
		"node": ">=24",
```

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants