Conversation
Bumps [lodash-es](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash-es dependency-version: 4.17.23 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…es-4.17.23 chore(deps): bump lodash-es from 4.17.21 to 4.17.23
Bumps [tar](https://github.com/isaacs/node-tar) from 7.4.3 to 7.5.4. - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v7.4.3...v7.5.4) --- updated-dependencies: - dependency-name: tar dependency-version: 7.5.4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
chore(deps): bump tar from 7.4.3 to 7.5.4
chore(deps): bump nx from 21.2.0 to 21.3.0
- Disable module concatenation and minification in dev mode - Add webpack filesystem caching for faster rebuilds - Enable HMR and optimize serve configuration
fix: upgrade cross-env to v10 and improve env replacement
fix: upgrade cross-env to v10 and improve env replacement
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
[Chore] Simplify Package Scripts
- Upgrade @angular/* core packages to ^20.2.4 - Upgrade @angular/cdk and @angular/material to ^20.2.14 - Upgrade @angular-devkit/* packages to ^20.2.4 - Upgrade @angular-eslint/* packages to ^20.2.4 - Upgrade @angular/cli to ~20.2.0 - Upgrade @angular/compiler-cli to ^20.2.0 - Upgrade @schematics/angular to 20.2.2 - Set @angular-devkit/architect to ^0.2002.0
…lity Fix: Checkbox theme compatibility & Register validation logic
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
|
|
|
|
🤖 Augment PR SummarySummary: This PR updates the workspace “stage” dependencies and build tooling, primarily around Angular/Nx and related developer workflows. Changes:
Technical Notes: Most changes are configuration/tooling oriented; pay special attention to build/test target behavior changes and dev/prod webpack optimization toggles. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| // Disable module concatenation in development - it's slow and not needed | ||
| concatenateModules: !isDev, | ||
| // Only minimize in production builds | ||
| minimize: !isCircleCI && !isDev, |
There was a problem hiding this comment.
isCircleCI is a function, so !isCircleCI will always be false and optimization.minimize ends up disabled for all builds. Did you mean to call it (!isCircleCI()) or use the computed boolean (!isCircleEnv)?
🤖 Was this useful? React with 👍 or 👎
Greptile OverviewGreptile SummaryThis PR upgrades Angular packages from 20.0.x to 20.2.x, Nx from 21.2.0 to 21.5.1, and webpack to 5.101.3. It also includes several build optimizations and configuration improvements:
PR Description Issue: The PR description is incomplete - the checkboxes are not marked and no explanation of changes is provided. Per custom rule 90653f25-bd57-4517-ae57-772fe2013d9c, this could result in the PR being closed without comment. Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Yarn as Yarn Package Manager
participant Build as Build System
participant Webpack as Webpack Config
participant Nx as Nx Build Tool
participant Angular as Angular CLI
Dev->>Yarn: yarn install
Yarn->>Yarn: Resolve dependencies (Angular 20.2.x, Nx 21.5.1)
Dev->>Build: yarn build
Build->>Nx: Execute build target
Nx->>Angular: @nx/angular:build
alt Development Mode
Angular->>Webpack: Apply custom config
Webpack->>Webpack: isDevelopment() = true
Webpack->>Webpack: Enable filesystem cache
Webpack->>Webpack: Disable concatenateModules
Webpack->>Webpack: Disable minification
Webpack-->>Angular: Fast build output
else Production Mode
Angular->>Webpack: Apply custom config
Webpack->>Webpack: isDevelopment() = false
Webpack->>Webpack: Enable concatenateModules
Webpack->>Webpack: Enable TerserPlugin minification
Webpack-->>Angular: Optimized build output
end
Angular-->>Nx: Build complete
Nx-->>Build: Build artifacts
Build-->>Dev: Application ready
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 issues found across 67 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/plugins/posthog-ui/project.json">
<violation number="1" location="packages/plugins/posthog-ui/project.json:29">
P2: @nx/jest:jest no longer supports the tsConfig option in Nx 21+, so this addition will be rejected or ignored. Remove tsConfig from the test target and keep configuration inside jest.config.ts instead.</violation>
</file>
<file name="apps/gauzy/config/custom-webpack.config.js">
<violation number="1" location="apps/gauzy/config/custom-webpack.config.js:50">
P2: `minimize` is always false because `isCircleCI` is a function reference (truthy). Use the computed `isCircleEnv` boolean so production builds can still minify.</violation>
</file>
<file name="packages/ui-core/project.json">
<violation number="1" location="packages/ui-core/project.json:51">
P2: The @nx/jest:jest executor in Nx 21 no longer supports a `tsConfig` option; adding it will fail schema validation or be ignored. Move tsconfig configuration into jest.config.ts (e.g., jest-preset-angular/ts-jest config) or remove this option.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| "jestConfig": "packages/plugins/posthog-ui/jest.config.ts", | ||
| "tsConfig": "packages/plugins/posthog-ui/tsconfig.spec.json" |
There was a problem hiding this comment.
P2: @nx/jest:jest no longer supports the tsConfig option in Nx 21+, so this addition will be rejected or ignored. Remove tsConfig from the test target and keep configuration inside jest.config.ts instead.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/plugins/posthog-ui/project.json, line 29:
<comment>@nx/jest:jest no longer supports the tsConfig option in Nx 21+, so this addition will be rejected or ignored. Remove tsConfig from the test target and keep configuration inside jest.config.ts instead.</comment>
<file context>
@@ -4,47 +4,36 @@
+ "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
"options": {
- "jestConfig": "packages/plugins/posthog-ui/jest.config.ts"
+ "jestConfig": "packages/plugins/posthog-ui/jest.config.ts",
+ "tsConfig": "packages/plugins/posthog-ui/tsconfig.spec.json"
}
</file context>
| "jestConfig": "packages/plugins/posthog-ui/jest.config.ts", | |
| "tsConfig": "packages/plugins/posthog-ui/tsconfig.spec.json" | |
| "jestConfig": "packages/plugins/posthog-ui/jest.config.ts" |
| // Disable module concatenation in development - it's slow and not needed | ||
| concatenateModules: !isDev, | ||
| // Only minimize in production builds | ||
| minimize: !isCircleCI && !isDev, |
There was a problem hiding this comment.
P2: minimize is always false because isCircleCI is a function reference (truthy). Use the computed isCircleEnv boolean so production builds can still minify.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/gauzy/config/custom-webpack.config.js, line 50:
<comment>`minimize` is always false because `isCircleCI` is a function reference (truthy). Use the computed `isCircleEnv` boolean so production builds can still minify.</comment>
<file context>
@@ -2,25 +2,54 @@ const TerserPlugin = require('terser-webpack-plugin');
+ // Disable module concatenation in development - it's slow and not needed
+ concatenateModules: !isDev,
+ // Only minimize in production builds
+ minimize: !isCircleCI && !isDev,
+ // Only use Terser in production builds
+ minimizer: isDev ? [] : [
</file context>
| minimize: !isCircleCI && !isDev, | |
| minimize: !isCircleEnv && !isDev, |
| "options": { | ||
| "jestConfig": "packages/ui-core/jest.config.ts" | ||
| "jestConfig": "packages/ui-core/jest.config.ts", | ||
| "tsConfig": "packages/ui-core/tsconfig.spec.json" |
There was a problem hiding this comment.
P2: The @nx/jest:jest executor in Nx 21 no longer supports a tsConfig option; adding it will fail schema validation or be ignored. Move tsconfig configuration into jest.config.ts (e.g., jest-preset-angular/ts-jest config) or remove this option.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/ui-core/project.json, line 51:
<comment>The @nx/jest:jest executor in Nx 21 no longer supports a `tsConfig` option; adding it will fail schema validation or be ignored. Move tsconfig configuration into jest.config.ts (e.g., jest-preset-angular/ts-jest config) or remove this option.</comment>
<file context>
@@ -47,7 +47,8 @@
"options": {
- "jestConfig": "packages/ui-core/jest.config.ts"
+ "jestConfig": "packages/ui-core/jest.config.ts",
+ "tsConfig": "packages/ui-core/tsconfig.spec.json"
}
},
</file context>
3 participants
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
Summary by cubic
Upgrades Angular/Nx to 20.2.x/21.5.1 and optimizes the dev build for faster feedback. Also fixes checkbox theme styling and makes Register full-name validation respect config.
Performance
Dependencies
Written for commit 30a5db2. Summary will update on new commits.