Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
"@typescript-eslint/parser": "^8.0.0",
"babel-jest": "^27.4.5",
"babel-preset-jest": "^27.4.5",
"eslint": "^8.42.0",
"eslint": "^9.26.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check that ESLint 9 works with the legacy .eslintrc.js config in apps/api/. ESLint 9 defaults to flat config format - may need ESLINT_USE_FLAT_CONFIG=false or config migration.

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/api/package.json
Line: 96:96

Comment:
Check that ESLint 9 works with the legacy `.eslintrc.js` config in `apps/api/`. ESLint 9 defaults to flat config format - may need `ESLINT_USE_FLAT_CONFIG=false` or config migration.

How can I resolve this? If you propose a fix, please make it concise.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint v9 makes eslint.config.* (flat config) the default and (per ESLint’s v9 migration notes) no longer automatically searches for .eslintrc.*; since this repo still has .eslintrc.js in apps/api and .eslintrc.json in apps/portal, please ensure the lint commands still load the intended config after this upgrade.

Other Locations
  • apps/portal/package.json:85
  • package.json:50

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

"eslint-config-prettier": "^9.0.0",
"eslint-plugin-prettier": "^5.0.0",
"jest": "^29.5.0",
Expand Down
2 changes: 1 addition & 1 deletion apps/portal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"@types/react-dom": "^18.3.1",
"autoprefixer": "^9.8.8",
"cssnano": "^4.1.11",
"eslint": "^8",
"eslint": "^9",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/portal still uses eslint-config-next@14.2.11, which declares a peer dependency on eslint ^7.23.0 || ^8.0.0 (no v9), so bumping eslint to ^9 here is likely to cause peer-dep/install issues and may break next lint.

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

"eslint-config-next": "14.2.11",
Comment on lines +85 to 86
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify eslint-config-next 14.2.11 compatibility with ESLint 9. Next.js 15+ officially supports ESLint 9, but v14 may require compatibility flags.

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/portal/package.json
Line: 85:86

Comment:
Verify `eslint-config-next` 14.2.11 compatibility with ESLint 9. Next.js 15+ officially supports ESLint 9, but v14 may require compatibility flags.

How can I resolve this? If you propose a fix, please make it concise.

"eslint-config-prettier": "^10.1.8",
"jest": "^27.5.1",
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"nohoist": []
},
"devDependencies": {
"eslint": "^8.57.1",
"eslint": "^9.26.0",
"eslint-config-prettier": "^8.10.0",
"eslint-plugin-react": "^7.37.4",
Comment on lines +50 to 52
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider updating eslint-config-prettier from 8.10.0 to 9.0.0+ for official ESLint 9 support.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 50:52

Comment:
Consider updating `eslint-config-prettier` from 8.10.0 to 9.0.0+ for official ESLint 9 support.

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

"husky": "^9.1.7",
Expand Down
Loading