Skip to content

Fix Groupby display name for Valuedrift metrics #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sudharsan-T wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Groupby display name for Valuedrift metrics #1785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/evidently/metrics/group_by.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ class GroupByMetricCalculation(MetricCalculation[TResult, GroupByMetric]):
def calculate(self, context: "Context", current_data: Dataset, reference_data: Optional[Dataset]):
curr = current_data.subdataset(self.metric.column_name, self.metric.label)
ref = reference_data.subdataset(self.metric.column_name, self.metric.label) if reference_data else None
dn = self.calculation.display_name
self.calculation.display_name = _patched_display_name(dn, self.metric) # type: ignore[method-assign]
res = self.calculation.calculate(context, curr, ref)
if isinstance(res, tuple):
curr_res, ref_res = res
Expand All @@ -48,9 +46,8 @@ def calculate(self, context: "Context", current_data: Dataset, reference_data: O
return curr_res, ref_res

def display_name(self) -> str:
return (
f"{self.calculation.display_name()} group by '{self.metric.column_name}' for label: '{self.metric.label}'"
)
base = self.calculation.display_name()
return f"{base} group by '{self.metric.column_name}' for label: '{self.metric.label}'"

@property
def column_name(self) -> str:
Expand Down
Loading