fix: Pass Google Fonts fontspector QA for the variable font - #10
Draft
psd-coder wants to merge 12 commits into
Draft
fix: Pass Google Fonts fontspector QA for the variable font#10psd-coder wants to merge 12 commits into
psd-coder wants to merge 12 commits into
Conversation
sources/check.sh runs the Google Fonts profile against MartianGrotesk[wdth,wght].ttf, forwards extra args (e.g. -l fail), and accepts an explicit font path to override the default target
Add SemiBold (600), drop UltraBlack from the wght STAT values; googlefonts/STAT/compulsory_axis_values now passes. SemiBold needs no master. STAT axis values label locations in the continuous variable design space, not discrete masters: wght spans 100-1000, so 600 is interpolated and already an fvar named instance. The STAT block merely lacked the matching label. UltraBlack: not in the GF Axis Registry.
psd-coder
marked this pull request as draft
June 3, 2026 11:54
10 tasks
|
Visit the preview URL for this PR (updated for commit 31acfc2): https://grotesk-comparison-stand--pr-10-twgr1eth.web.app (expires Sun, 27 Sep 2026 22:19:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 79b50decca688a9a18871c69fe0ecb3e872353de |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Brings Martian Grotesk into compliance with Google Fonts QA by resolving the failures reported by fontspector (GF profile), and adds the tooling to run those checks. Covers undrawn Cyrillic glyphs, STAT weight-axis values, master/style naming, and export hygiene.
Problem Statement
The variable font did not pass Google Fonts' automated QA (fontspector, GF profile), which blocks submission to Google Fonts. The notable failures:
contour_count/ no-contour): several Cyrillic letters (Ө, Ӫ, ө, ӫ, Ӛ, ӛ, ə and related) carried Unicode codepoints but had no contours.Solution Approach