Fix bg modes#46
Merged
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 58ca247): https://harmonizer-web--pr46-fix-bg-modes-o9nqm12c.web.app (expires Sat, 23 Aug 2025 22:24:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0b46b8946d697564b3f98633c5cd230a6ede1236 |
psd-coder
force-pushed
the
fix-bg-modes
branch
from
03ec2b3 to
003f3f6
Compare
…ted because use could put light color into dark background input and vice versa
psd-coder
force-pushed
the
fix-bg-modes
branch
from
003f3f6 to
1efe65d
Compare
…ly built. This reverts commit 1efe65d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fixes such weird situtations:
What was changed
Background color stores were renamed to left & right, instead of dark & light, because we don't limit which color user can put it into them and when you refer them it might not be clear. Besides that bgMode concept was separated from the background itself. This improves clarity and flexibility in managing background styles for different grid sections.