Push ovtzkltnlnkw #124
Merged
Push ovtzkltnlnkw #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This strips unused symbols, and also makes the STL work.
evmar
force-pushed
the
push-ovtzkltnlnkw
branch
3 times, most recently
from
9787682 to
da5a3cc
Compare
Unfortunately Rust has deprecated support for the Windows we target. Previous changes have replaced the Rust test programs with C++ versions. Using Rust to write minimal Windows programs was kind of an uphill battle anyway, e.g. the windows crate requires std to use DirectDraw (for COM reasons, is my recollection) while we didn't want std; rust-analyzer hated the use of x86 assembly; etc. Getting the Windows programs small was its own fight (e.g. calling "new" pulls in a bunch of STL goop) but I think overall it has been relatively easier. We unfortunately lose the 'zip' test. Ironically I had originally written this in C++, then migrated it to Rust to be able to reuse a crate. I guess I could go back to pasting in a C++ zip implementation in the tree. See discussion in rust-lang/rust#116344 , which was the last issue where this point was finally forced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.