More stubs and some implementations #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
force-pushed
the
pr/more_stubs
branch
3 times, most recently
from
5dca7ce to
40032e5
Compare
evmar
reviewed
Jan 1, 2025
Owner
evmar
left a comment
evmar
left a comment
There was a problem hiding this comment.
This looks basically perfect. Two of my comments are just "did you consider this or not", feel free to ignore or add a TODO or whatever.
I've checked this against ReactOS, which does the lookup using _wcsnicmp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additional fixes. Let me know if something is more controversial, I would be happy to split such things into separate PRs.