fix: Validate Log topics are 32-byte hex strings#168
Closed
roninjin10 wants to merge 1 commit intomainfrom
Closed
Conversation
Fixes #91. Log.from() now validates that each topic is either: - A Uint8Array of exactly 32 bytes - A valid 64-character hex string (with optional 0x prefix) Throws InvalidLengthError for wrong length topics and InvalidFormatError for invalid hex or type. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
roninjin10
commented
Jan 4, 2026
Contributor
Author
roninjin10
left a comment
roninjin10
left a comment
There was a problem hiding this comment.
Automated review summary for PR #168 — fix: Validate Log topics are 32-byte hex strings\n\nTouched areas: EventLog | Files changed: 2 (+243/-1)\n\n- Tests: yes\n- Types & API: yes\n- Docs: ensure behavior is documented where user-facing.\n- Performance: consider micro-allocations in tight loops.\n\nOutcome: Comment-only review; no blocking issues spotted. Please consider the above suggestions.\n
Contributor
Author
|
Duplicate of merged PR #277 (EventLog topic validation) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Log.from()now validates topics are valid 32-byte hex stringsInvalidLengthErrorfor wrong length topicsInvalidFormatErrorfor invalid hex characters or wrong typesTest plan
🤖 Generated with Claude Code