🐛 fix: BloomFilter now uses Keccak-256 per Yellow Paper#265
Merged
roninjin10 merged 1 commit intomainfrom Jan 4, 2026
Merged
Conversation
BloomFilter was using a simple multiplicative hash function instead of Ethereum's specified algorithm. Per Yellow Paper m(x,i) = KEC(x)[i,i+1] mod 2048, bloom filter bit positions must be derived from Keccak-256 hash bytes. This fix: - Updates hash.js to use Keccak-256 and extract bit positions from byte pairs - Adds hashFromKeccak() for efficiency when computing multiple seeds - Updates add.js and contains.js to compute Keccak once per item - Adds Yellow Paper compliance tests with known bit position verification Fixes #110 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
roninjin10
commented
Jan 4, 2026
Contributor
Author
roninjin10
left a comment
roninjin10
left a comment
There was a problem hiding this comment.
Automated review summary for PR #265 — 🐛 fix: BloomFilter now uses Keccak-256 per Yellow Paper\n\nTouched areas: BloomFilter | Files changed: 5 (+172/-15)\n\n- Tests: yes\n- Types & API: yes\n- Docs: ensure behavior is documented where user-facing.\n- Performance: consider micro-allocations in tight loops.\n\nFocus points:\n - Validate Keccak-256 endianness and 3-bit mapping per Yellow Paper.\n - Add fixture tests vs known Ethereum logs (positive/negative).\n\nOutcome: Comment-only review; no blocking issues spotted. Please consider the above suggestions.\n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code