Skip to content

✅ test: Document ECDSA recovery validates v value#274

Merged
roninjin10 merged 1 commit intomainfrom
fix/issue-97-ecdsa-recovery
Jan 4, 2026
Merged

✅ test: Document ECDSA recovery validates v value#274
roninjin10 merged 1 commit intomainfrom
fix/issue-97-ecdsa-recovery

Conversation

@roninjin10
Copy link
Contributor

Summary

Test plan

  • v=2 throws
  • v=26 throws
  • v=29 throws
  • v=255 throws
  • Valid v values work

🤖 Generated with Claude Code

Fixes #97 - The implementation already validates that v must be 0, 1,
27, or 28 and throws InvalidSignatureError for other values. Added
comprehensive tests documenting this security behavior for edge cases
like v=2, v=26, v=29, v=255, and negative values.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Jan 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
dist Error Error Jan 4, 2026 11:07am
voltaire Error Error Jan 4, 2026 11:07am

@roninjin10 roninjin10 merged commit 394f8d7 into main Jan 4, 2026
19 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: ECDSA recovery with invalid v value doesn't throw

1 participant