Skip to content

🐛 fix: BlockHash.fromBytes returns copy instead of reference#284

Merged
roninjin10 merged 1 commit intomainfrom
fix/issue-73-blockhash-copy
Jan 4, 2026
Merged

🐛 fix: BlockHash.fromBytes returns copy instead of reference#284
roninjin10 merged 1 commit intomainfrom
fix/issue-73-blockhash-copy

Conversation

@roninjin10
Copy link
Contributor

Summary

Test plan

  • Input mutation doesn't affect BlockHash
  • Normal usage works correctly

🤖 Generated with Claude Code

fromBytes was returning input directly, allowing external mutation.
Now creates a copy to prevent unintended side effects.

Fixes #73

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Jan 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
dist Error Error Jan 4, 2026 0:16am
voltaire Error Error Jan 4, 2026 0:16am

@roninjin10 roninjin10 merged commit 69c74d0 into main Jan 4, 2026
19 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: BlockHash.fromBytes returns reference instead of copy

1 participant